Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2886)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java

Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only (Closed)
Patch Set: Replace |Refresh| return value with treib@'s revalidation event Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/logo_bridge.h » ('j') | chrome/browser/android/logo_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
index d38337333bab4fe38381f1fccce40f6e2d2b6d16..500fc2d24272351828940ed5c98b19fa5e09dac7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
@@ -38,7 +38,7 @@ public class LogoDelegateImpl implements LogoView.Delegate {
private String mOnLogoClickUrl;
private String mAnimatedLogoUrl;
- private boolean mHasRecordedLoadTime;
+ private boolean mShouldRecordLoadTime;
private boolean mIsDestroyed;
@@ -51,6 +51,7 @@ public class LogoDelegateImpl implements LogoView.Delegate {
mTab = tab;
mLogoView = logoView;
mLogoBridge = new LogoBridge(tab.getProfile());
+ mShouldRecordLoadTime = true;
}
@Override
@@ -94,13 +95,15 @@ public class LogoDelegateImpl implements LogoView.Delegate {
if (logo != null) {
RecordHistogram.recordSparseSlowlyHistogram(LOGO_SHOWN_UMA_NAME,
logo.animatedLogoUrl == null ? STATIC_LOGO_SHOWN : CTA_IMAGE_SHOWN);
- if (!mHasRecordedLoadTime) {
+ if (mShouldRecordLoadTime) {
long loadTime = System.currentTimeMillis() - loadTimeStart;
RecordHistogram.recordMediumTimesHistogram(
LOGO_SHOWN_TIME_UMA_NAME, loadTime, TimeUnit.MILLISECONDS);
- mHasRecordedLoadTime = true;
}
}
+ // If there currently is no Doodle, don't record the time if a refresh happens
+ // later.
+ mShouldRecordLoadTime = false;
logoObserver.onLogoAvailable(logo, fromCache);
}
};
« no previous file with comments | « no previous file | chrome/browser/android/logo_bridge.h » ('j') | chrome/browser/android/logo_bridge.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698