components/doodle/doodle_service.h - Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/doodle/doodle_service.h

Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only (Closed)

Patch Set: Fix compile errors and comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/doodle/doodle_service.h

diff --git a/components/doodle/doodle_service.h b/components/doodle/doodle_service.h

index e4a9792a99149bad9e08cf054aad14232881ae96..5d0124157edf031d3147aeb2e0f1755fbbe091c1 100644

--- a/components/doodle/doodle_service.h

+++ b/components/doodle/doodle_service.h

@@ -58,8 +58,8 @@ class DoodleService : public KeyedService {

// Requests an asynchronous refresh of the DoodleConfig from the network.

// After the update completes, the observers will be notified only if the

- // config changed.

- void Refresh();

+ // config changed. Returns true if a network request was actually sent.

+ bool Refresh();

private:

// Note: Keep in sync with the corresponding enum in histograms.xml. Never