chrome/browser/android/logo_bridge.h - Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/logo_bridge.h

Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only (Closed)

Patch Set: Remove skippedCallback and call onLogoAvailable more explicitly Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/logo_bridge.h

diff --git a/chrome/browser/android/logo_bridge.h b/chrome/browser/android/logo_bridge.h

index 89f5f48b12a3ecf1dbc0e09e08098b45d4aee407..cf05c56c6e7718f371d4b81f9b04cfbe2c7ce6a4 100644

--- a/chrome/browser/android/logo_bridge.h

+++ b/chrome/browser/android/logo_bridge.h

@@ -63,10 +63,8 @@ class LogoBridge : public doodle::DoodleService::Observer {

void OnDoodleConfigUpdated(

const base::Optional<doodle::DoodleConfig>& maybe_doodle_config) override;

- void DoodleConfigReceived(

- const base::Optional<doodle::DoodleConfig>& maybe_doodle_config,

- bool from_cache);

+ void NotifyNoLogoAvailable(bool from_cache);

+ void FetchDoodleImage(const doodle::DoodleConfig& doodle_config);

void DoodleImageFetched(bool config_from_cache,

const GURL& on_click_url,

const std::string& alt_text,