Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: components/doodle/doodle_service.h

Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only (Closed)
Patch Set: Split refresh callback into own interface Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/doodle/doodle_service.h
diff --git a/components/doodle/doodle_service.h b/components/doodle/doodle_service.h
index e4a9792a99149bad9e08cf054aad14232881ae96..705dbfafb63d20e4974713b8e6a856147d3da5b5 100644
--- a/components/doodle/doodle_service.h
+++ b/components/doodle/doodle_service.h
@@ -59,7 +59,9 @@ class DoodleService : public KeyedService {
// Requests an asynchronous refresh of the DoodleConfig from the network.
// After the update completes, the observers will be notified only if the
// config changed.
- void Refresh();
+ // Returns false if no fetch was issued because the service has fresh data in
Marc Treib 2017/04/26 10:17:16 nit: No newline. Also, maybe just "Returns whether
fhorschig 2017/04/27 10:31:44 Hm? There is no unnecessary newline, or am I missi
Marc Treib 2017/04/27 11:15:50 I meant that there's a line break in the comment t
fhorschig 2017/04/27 11:49:20 Done.
+ // it's cache.
+ bool Refresh();
private:
// Note: Keep in sync with the corresponding enum in histograms.xml. Never

Powered by Google App Engine
This is Rietveld 408576698