Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4937)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java

Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only (Closed)
Patch Set: Split refresh callback into own interface Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
index ef79a9140beb69e3095715ad724eb0babc65d8e8..d45b8478b41943c8c1e33a09ed5ed7f72caeb543 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
@@ -56,7 +56,7 @@ public class LogoBridge {
* Called when the cached or fresh logo is available. This may be called up to two times,
* once with the cached logo and once with a freshly downloaded logo.
*
- * @param logo The search provider's logo.
+ * @param logo The search provider's logo.
* @param fromCache Whether the logo was loaded from the cache.
*/
@CalledByNative("LogoObserver")
@@ -64,6 +64,18 @@ public class LogoBridge {
}
/**
+ * A callback that is called if DoodleService::Refresh was triggered but skipped any requests.
+ * */
+ public interface RefreshCallbackWrapper {
Marc Treib 2017/04/26 10:17:16 Just RefreshCallback, or RefreshStatusCallback or
fhorschig 2017/04/27 10:31:43 Gone.
+ /**
+ * Called when an explicitly triggered refresh was skipped (e.g. because the service has
+ * been refreshed recently).
+ */
+ @CalledByNative("LogoRefreshCallback")
+ void onRefreshSkipped();
+ }
+
+ /**
* A callback that is called when the animated logo is successfully downloaded.
*/
public interface AnimatedLogoCallback {
@@ -105,8 +117,8 @@ public class LogoBridge {
* available. logoObserver.onLogoAvailable() may be called synchronously if
* the cached logo is already available.
*/
- void getCurrentLogo(LogoObserver logoObserver) {
- nativeGetCurrentLogo(mNativeLogoBridge, logoObserver);
+ void getCurrentLogo(LogoObserver logoObserver, RefreshCallbackWrapper refreshCallbackWrapper) {
+ nativeGetCurrentLogo(mNativeLogoBridge, logoObserver, refreshCallbackWrapper);
}
/**
@@ -131,7 +143,8 @@ public class LogoBridge {
}
private native long nativeInit(Profile profile);
- private native void nativeGetCurrentLogo(long nativeLogoBridge, LogoObserver logoObserver);
+ private native void nativeGetCurrentLogo(long nativeLogoBridge, LogoObserver logoObserver,
+ RefreshCallbackWrapper refreshCallbackWrapper);
private native void nativeGetAnimatedLogo(long nativeLogoBridge, AnimatedLogoCallback callback,
String gifUrl);
private native void nativeDestroy(long nativeLogoBridge);

Powered by Google App Engine
This is Rietveld 408576698