Record NTP.LogoShownTime for timely refreshs only

components/doodle/doodle_service.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOODLE_DOODLE_SERVICE_H_
 #define COMPONENTS_DOODLE_DOODLE_SERVICE_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "base/optional.h"
 #include "base/time/clock.h"
 #include "base/time/tick_clock.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "components/doodle/doodle_fetcher.h"
 #include "components/doodle/doodle_types.h"
 #include "components/keyed_service/core/keyed_service.h"
 
 class PrefRegistrySimple;
 class PrefService;
 
 namespace doodle {
 
 class DoodleService : public KeyedService {
  public:
   class Observer {
    public:
+    virtual void OnDoodleConfigRevalidated(bool from_cache) = 0;
     virtual void OnDoodleConfigUpdated(const base::Optional<DoodleConfig>&) = 0;
   };
 
   static void RegisterProfilePrefs(PrefRegistrySimple* pref_registry);
 
   // All pointer parameters must be non-null. If |min_refresh_interval| doesn't
   // have a value, the default value is used.
   DoodleService(PrefService* pref_service,
                 std::unique_ptr<DoodleFetcher> fetcher,
                 std::unique_ptr<base::OneShotTimer> expiry_timer,
@@ skipping 10 matching lines @@
 
   // Adds a new observer to the service. It'll only be called when the config
   // changes; to get the current (cached) config, call |config()|.
   void AddObserver(Observer* observer);
 
   // Prevents |observer| from receiving future updates. This is safe to call
   // even when the observer is being notified of an update.
   void RemoveObserver(Observer* observer);
 
   // Requests an asynchronous refresh of the DoodleConfig from the network.
-  // After the update completes, the observers will be notified only if the
-  // config changed.
+  // After the update completes, the observers will be notified whether the
+  // config changes or active configs remain valid.

[Marc Treib, 2017/04/27 15:22:55]

s/changes/changed/
s/active configs remain/the active config remains/

[fhorschig, 2017/04/28 08:20:07]

Done.

   void Refresh();
 
  private:
   // Note: Keep in sync with the corresponding enum in histograms.xml. Never
   // remove values, and only insert new values at the end.
   enum DownloadOutcome {
     OUTCOME_NEW_DOODLE = 0,
     OUTCOME_REVALIDATED_DOODLE = 1,
     OUTCOME_CHANGED_DOODLE = 2,
     OUTCOME_NO_DOODLE = 3,
@@ skipping 53 matching lines @@
 
   // The list of observers to be notified when the DoodleConfig changes.
   base::ObserverList<Observer> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(DoodleService);
 };
 
 }  // namespace doodle
 
 #endif  // COMPONENTS_DOODLE_DOODLE_SERVICE_H_