Record NTP.LogoShownTime for timely refreshs only

components/doodle/doodle_service.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOODLE_DOODLE_SERVICE_H_
 #define COMPONENTS_DOODLE_DOODLE_SERVICE_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 41 matching lines @@
   // changes; to get the current (cached) config, call |config()|.
   void AddObserver(Observer* observer);
 
   // Prevents |observer| from receiving future updates. This is safe to call
   // even when the observer is being notified of an update.
   void RemoveObserver(Observer* observer);
 
   // Requests an asynchronous refresh of the DoodleConfig from the network.
   // After the update completes, the observers will be notified only if the
   // config changed.
-  void Refresh();
+  // Returns true if the refresh actually triggered a fetch. Returns false if
+  // refreshing was skipped (because the refresh interval hasn't passed yet).

[tschumann, 2017/04/20 18:53:11]

nit: i'd simplify the last sentence. what about:
Returns false if no fetch was issued because the service has fresh data in it's
cache.
 

[fhorschig, 2017/04/24 13:52:34]

Sounds good!

+  bool Refresh();
 
  private:
   // Note: Keep in sync with the corresponding enum in histograms.xml. Never
   // remove values, and only insert new values at the end.
   enum DownloadOutcome {
     OUTCOME_NEW_DOODLE = 0,
     OUTCOME_REVALIDATED_DOODLE = 1,
     OUTCOME_CHANGED_DOODLE = 2,
     OUTCOME_NO_DOODLE = 3,
     OUTCOME_EXPIRED = 4,
@@ skipping 52 matching lines @@
 
   // The list of observers to be notified when the DoodleConfig changes.
   base::ObserverList<Observer> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(DoodleService);
 };
 
 }  // namespace doodle
 
 #endif  // COMPONENTS_DOODLE_DOODLE_SERVICE_H_