Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: net/spdy/spdy_framer_test.cc

Issue 283343003: Cleanup: Remove redundant SpdyFramerTest string conversions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer_test.cc
diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc
index 27e7123eb40a5dd65346fe37e0c616aa87ae61be..2a005bb946a6be1f56d64ed0ff4a7fb570576137 100644
--- a/net/spdy/spdy_framer_test.cc
+++ b/net/spdy/spdy_framer_test.cc
@@ -3054,7 +3054,7 @@ TEST_P(SpdyFramerTest, ControlFrameAtMaxSizeLimit) {
// Create a frame at exactly that size.
string big_value(kBigValueSize, 'x');
- syn_stream.SetHeader("aa", big_value.c_str());
+ syn_stream.SetHeader("aa", big_value);
control_frame.reset(framer.SerializeSynStream(syn_stream));
EXPECT_TRUE(control_frame.get() != NULL);
EXPECT_EQ(framer.GetControlFrameBufferMaxSize(), control_frame->size());
@@ -3089,7 +3089,7 @@ TEST_P(SpdyFramerTest, ControlFrameTooLarge) {
// Create a frame at exatly that size.
string big_value(kBigValueSize, 'x');
- syn_stream.SetHeader("aa", big_value.c_str());
+ syn_stream.SetHeader("aa", big_value);
// Upstream branches here and wraps SPDY4 with EXPECT_DEBUG_DFATAL. We
// neither support that in Chromium, nor do we use the same DFATAL (see
// SpdyFrameBuilder::WriteFramePrefix()).
@@ -3124,7 +3124,7 @@ TEST_P(SpdyFramerTest, TooLargeHeadersFrameUsesContinuation) {
// enough to cause an overflow.
const size_t kBigValueSize = framer.GetControlFrameBufferMaxSize();
string big_value(kBigValueSize, 'x');
- headers.SetHeader("aa", big_value.c_str());
+ headers.SetHeader("aa", big_value);
scoped_ptr<SpdyFrame> control_frame(framer.SerializeHeaders(headers));
EXPECT_TRUE(control_frame.get() != NULL);
EXPECT_GT(control_frame->size(), framer.GetControlFrameBufferMaxSize());
@@ -3152,7 +3152,7 @@ TEST_P(SpdyFramerTest, TooLargePushPromiseFrameUsesContinuation) {
// enough to cause an overflow.
const size_t kBigValueSize = framer.GetControlFrameBufferMaxSize();
string big_value(kBigValueSize, 'x');
- push_promise.SetHeader("aa", big_value.c_str());
+ push_promise.SetHeader("aa", big_value);
scoped_ptr<SpdyFrame> control_frame(
framer.SerializePushPromise(push_promise));
EXPECT_TRUE(control_frame.get() != NULL);
@@ -3182,7 +3182,7 @@ TEST_P(SpdyFramerTest, ControlFrameMuchTooLarge) {
SpdySynStreamIR syn_stream(1);
syn_stream.set_priority(1);
syn_stream.set_fin(true);
- syn_stream.SetHeader("aa", big_value.c_str());
+ syn_stream.SetHeader("aa", big_value);
scoped_ptr<SpdyFrame> control_frame(framer.SerializeSynStream(syn_stream));
EXPECT_TRUE(control_frame.get() != NULL);
TestSpdyVisitor visitor(spdy_version_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698