Reuse FileTasks when entries are not changed.

ui/file_manager/file_manager/foreground/js/task_controller.js

Index: ui/file_manager/file_manager/foreground/js/task_controller.js
diff --git a/ui/file_manager/file_manager/foreground/js/task_controller.js b/ui/file_manager/file_manager/foreground/js/task_controller.js
index a703d14c00d7f9c8d5a5109887dd38fb1940e018..1ce91507a1f8ba649211c1a9326c493a0f1cc995 100644
--- a/ui/file_manager/file_manager/foreground/js/task_controller.js
+++ b/ui/file_manager/file_manager/foreground/js/task_controller.js
@@ -262,7 +262,6 @@ TaskController.prototype.getMimeType_ = function(entry) {
  * @private
  */
 TaskController.prototype.onSelectionChanged_ = function() {
-  this.tasks_ = null;
   var selection = this.selectionHandler_.selection;
   // Caller of update context menu task items.
   // FileSelectionHandler.EventType.CHANGE
@@ -286,15 +285,36 @@ TaskController.prototype.updateTasks_ = function() {
   var selection = this.selectionHandler_.selection;
   if (this.dialogType_ === DialogType.FULL_PAGE &&
       (selection.directoryCount > 0 || selection.fileCount > 0)) {
-    this.getFileTasks()
-        .then(function(tasks) {
-          tasks.display(this.ui_.taskMenuButton);
-          this.updateContextMenuTaskItems_(tasks.getTaskItems());
-        }.bind(this))
-        .catch(function(error) {
-          if (error)
-            console.error(error.stack || error);
-        });
+    var previousFileTasksInvalidatePromise = new Promise(function(resolve) {
+      if (this.tasks_) {
+        this.getFileTasks()
+            .then(function(tasks) {
+              if (!tasks.areEntriesSame(selection.entries)) {
+                this.tasks_ = null;
+              }
+              resolve();
+            }.bind(this))
+            .catch(function(error) {
+              if (error)
+                console.log(error.stack || error);
+              this.tasks_ = null;
+              resolve();
+            }.bind(this));
+      } else {
+        resolve();
+      }
+    }.bind(this));
+    previousFileTasksInvalidatePromise.then(function() {
+      this.getFileTasks()
+          .then(function(tasks) {
+            tasks.display(this.ui_.taskMenuButton);
+            this.updateContextMenuTaskItems_(tasks.getTaskItems());
+          }.bind(this))
+          .catch(function(error) {
+            if (error)
+              console.error(error.stack || error);
+          });
+    }.bind(this));
   } else {
     this.ui_.taskMenuButton.hidden = true;
   }
@@ -309,19 +329,21 @@ TaskController.prototype.getFileTasks = function() {
     return this.tasks_;
 
   var selection = this.selectionHandler_.selection;
-  return selection.computeAdditional(this.metadataModel_).then(
-      function() {
-        if (this.selectionHandler_.selection !== selection)
-          return Promise.reject();
-        return FileTasks.create(
-            this.volumeManager_, this.metadataModel_, this.directoryModel_,
-            this.ui_, selection.entries, assert(selection.mimeTypes)).
-            then(function(tasks) {
-              if (this.selectionHandler_.selection !== selection)
-                return Promise.reject();
-              return tasks;
-            }.bind(this));
-      }.bind(this));
+  return this.tasks_ =

[fukino, 2017/04/25 09:06:10]

qq: Was this format change forced by PRESUBMIT checker?

[tetsui2, 2017/04/26 01:58:04]

Yes.

+             selection.computeAdditional(this.metadataModel_).then(function() {

[fukino, 2017/04/25 09:06:10]

We are getting metadata through foreground's metadataModel, so I don't expect we
get metadata O(n^2) times.

Maybe we should get metadata from cache if available in
https://codesearch.chromium.org/chromium/src/ui/file_manager/file_manager/for...
?

[tetsui2, 2017/04/26 01:58:04]

computeAdditional is working properly and as you expect it's not O(N^2). The
problem is FileTasks.create internally calls fileManagerPrivate.getFileTasks(),
which calls GetFileInfo N times in C++ code. Thus if FileTasks.create is called
N times, GetFileInfo is called O(N^2) times.

Regarding this, I suggested to discuss with mtomasz@ about
fileManagerPrivate.getFileTasks() improvement as he created
https://crbug.com/462989 previously.

FileManagerPrivateInternalGetFileTasksFunction::RunAsync():
https://codesearch.chromium.org/chromium/src/chrome/browser/chromeos/extensio...

+               if (this.selectionHandler_.selection !== selection)
+                 return Promise.reject();
+               return FileTasks
+                   .create(
+                       this.volumeManager_, this.metadataModel_,
+                       this.directoryModel_, this.ui_, selection.entries,
+                       assert(selection.mimeTypes))
+                   .then(function(tasks) {
+                     if (this.selectionHandler_.selection !== selection)
+                       return Promise.reject();
+                     return tasks;
+                   }.bind(this));
+             }.bind(this));
 };
 
 /**