Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2833413002: Revert "Use off-heap data for type feedback in PolymorphicInstanceCallInstr" (Closed)

Created:
3 years, 8 months ago by erikcorry
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use off-heap data for type feedback in PolymorphicInstanceCallInstr" This reverts commit d315a53e21ee4f3c80e9854354b69eba2161da43. SIMDBC debug mode failures. Revert of https://codereview.chromium.org/2809583002/ R=lrn@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2135c8a90f37091536bb6707edc5bf5a48bf315c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+895 lines, -834 lines) Patch
M runtime/vm/aot_optimizer.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M runtime/vm/assembler_arm.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 6 chunks +31 lines, -38 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 4 chunks +72 lines, -188 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +107 lines, -28 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +107 lines, -28 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +105 lines, -38 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 2 chunks +108 lines, -35 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +108 lines, -28 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 18 chunks +57 lines, -34 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/il_printer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/il_printer.cc View 3 chunks +5 lines, -47 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +9 lines, -74 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 7 chunks +25 lines, -200 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 3 chunks +28 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/jit_optimizer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 7 chunks +92 lines, -17 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 8 months ago (2017-04-24 11:46:47 UTC) #1
erikcorry
Committed patchset #1 (id:1) manually as 2135c8a90f37091536bb6707edc5bf5a48bf315c (presubmit successful).
3 years, 8 months ago (2017-04-24 11:56:40 UTC) #3
Lasse Reichstein Nielsen
3 years, 8 months ago (2017-04-24 11:56:55 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698