Issue 283333008: Stub for BBRv2, based on TCP congestion feedback frames.

Issue 283333008: Stub for BBRv2, based on TCP congestion feedback frames. (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana, jar (doing other things), Ian Swett

Base URL:
https://chromium.googlesource.com/chromium/src

Visibility:
Public.

More Reviews

Description

Stub for BBRv2, based on TCP congestion feedback frames. Merge internal change: 67154078 R=rch@chromium.org

Patch Set 2 : Implemented rch's comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
M	net/quic/congestion_control/receive_algorithm_interface.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/send_algorithm_interface.h	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	net/quic/congestion_control/send_algorithm_interface.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_connection_logger.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_protocol.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_protocol.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

LGTM, modulo two fixes. https://codereview.chromium.org/283333008/diff/1/net/quic/congestion_control/receive_algorithm_interface.cc File net/quic/congestion_control/receive_algorithm_interface.cc (right): https://codereview.chromium.org/283333008/diff/1/net/quic/congestion_control/receive_algorithm_interface.cc#newcode17 net/quic/congestion_control/receive_algorithm_interface.cc:17: case kTCPBBR: I think we ...

6 years, 7 months ago (2014-05-16 18:12:11 UTC) #2

ramant (doing other things)

6 years, 7 months ago (2014-05-16 18:36:24 UTC) #3

Thanks very much Ryan for the comments. Made the changes and merged them into
"Landing Recent QUIC Changes CL".

https://codereview.chromium.org/288313003/diff2/1:20001/net/quic/congestion_c...

https://codereview.chromium.org/288313003/diff2/1:20001/net/quic/quic_protoco...

https://codereview.chromium.org/283333008/diff/1/net/quic/congestion_control/...
File net/quic/congestion_control/receive_algorithm_interface.cc (right):

https://codereview.chromium.org/283333008/diff/1/net/quic/congestion_control/...
net/quic/congestion_control/receive_algorithm_interface.cc:17: case kTCPBBR:
On 2014/05/16 18:12:17, Ryan Hamilton wrote:
> I think we should DFATAL (or somesuch) if kTCPBBR is used. Same as
> kInterArrival...

Done.

https://codereview.chromium.org/283333008/diff/1/net/quic/quic_protocol.cc
File net/quic/quic_protocol.cc (right):

https://codereview.chromium.org/283333008/diff/1/net/quic/quic_protocol.cc#ne...
net/quic/quic_protocol.cc:524: case kTCPBBR: {
On 2014/05/16 18:12:17, Ryan Hamilton wrote:
> I think I'd also DFATAL here.

Done.

Expand Messages | Collapse Messages