Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 283333007: Add choke point for performing a fake endRecording (Closed)

Created:
6 years, 7 months ago by robertphillips
Modified:
6 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add choke point for performing a fake endRecording My goal here was to add a single location where we could patch up the created PicturePlayback. Unfortunately, the complexity of the recording process (e.g., the BBH) makes this quite complex. I will investigate altering the behavior of SkPicturePlayback to account for a potentially unbalanced set of saves/saveLayers. Committed: http://code.google.com/p/skia/source/detail?r=14773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M include/core/SkPicture.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPicture.cpp View 6 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 7 months ago (2014-05-16 15:25:06 UTC) #1
reed1
how does this effort fit into SkRecord?
6 years, 7 months ago (2014-05-19 12:17:22 UTC) #2
robertphillips
The real change is in: https://codereview.chromium.org/286033005/. This CL basically just makes it clearer where unbalanced ...
6 years, 7 months ago (2014-05-19 12:20:50 UTC) #3
reed1
lgtm
6 years, 7 months ago (2014-05-19 12:28:59 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-05-19 12:30:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/283333007/1
6 years, 7 months ago (2014-05-19 12:30:37 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 12:36:27 UTC) #7
Message was sent while issue was closed.
Change committed as 14773

Powered by Google App Engine
This is Rietveld 408576698