Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 283333002: Revert 174019 "Make ScriptLoader into a ResourceOwner" (Closed)

Created:
6 years, 7 months ago by Hajime Morrita
Modified:
6 years, 7 months ago
Reviewers:
Hajime Morrita
CC:
blink-reviews
Visibility:
Public.

Description

Revert 174019 "Make ScriptLoader into a ResourceOwner" > Make ScriptLoader into a ResourceOwner > > This change turns ScriptLoader a ResourceOwner, that ensures that > it subscribes Resource if the owner has a reference to it, and that > it unsubscribes the Resource otherwise. Before this change, > There are some situation where ScriptLoader has a reference to Resource > but doesn't subscribe it, that is error prone and left deleted instance > being subscribed. ResourceOwner guarantees reference and subscription > consistency. > > This is the second attempt to land this change. The original one was > reverted at r173996 because it caused a lot of crashes. These crahses > shouldn't happen with this revised version. > > TEST=script-cancel-crash.html > BUG=368551, 372242 > TBR=eseidel@chromium.org, japhet@chromium.org, dglazkov@chromium.org > > Review URL: https://codereview.chromium.org/288673002 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -137 lines) Patch
D trunk/LayoutTests/fast/dom/HTMLScriptElement/script-cancel-crash.html View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/LayoutTests/fast/dom/HTMLScriptElement/script-cancel-crash-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/Source/core/dom/ScriptLoader.h View 6 chunks +6 lines, -27 lines 0 comments Download
M trunk/Source/core/dom/ScriptLoader.cpp View 13 chunks +51 lines, -47 lines 0 comments Download
M trunk/Source/core/fetch/ResourceOwner.h View 4 chunks +6 lines, -11 lines 0 comments Download
M trunk/Source/core/html/parser/HTMLScriptRunner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/Source/core/html/parser/HTMLScriptRunner.cpp View 4 chunks +10 lines, -9 lines 0 comments Download
M trunk/Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hajime Morrita
6 years, 7 months ago (2014-05-15 07:20:32 UTC) #1
Hajime Morrita
6 years, 7 months ago (2014-05-15 07:20:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r174071.

Powered by Google App Engine
This is Rietveld 408576698