Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

Issue 2833313003: Pass clickEvent to controlElement inside label if targetNode can't start selection (Closed)
Patch Set: Added LayoutTestCase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
index e7201cc8106fcef156f23cda124b738045181e62..666eb8880dee4825fe3cbfd2e4883d0a699d109a 100644
--- a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
@@ -173,7 +173,8 @@ void HTMLLabelElement::DefaultEventHandler(Event* evt) {
.IsRange() &&
!frame->GetEventHandler()
.GetSelectionController()
- .MouseDownWasSingleClickInSelection())
+ .MouseDownWasSingleClickInSelection() &&
+ evt->target()->ToNode()->CanStartSelection())
is_label_text_selected = true;
// If selection is there and is single click i.e. text is
// selected by dragging over label text, then return.

Powered by Google App Engine
This is Rietveld 408576698