Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

Issue 2833313003: Pass clickEvent to controlElement inside label if targetNode can't start selection (Closed)
Patch Set: Address Review Comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/label/label-selection-by-textSelection-and-click.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
index 06670f2cf1a1c1623ce571f30741bf5481761a0d..7fc8dbe6160768fabf34a48a6ac32b589a756f21 100644
--- a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
@@ -173,7 +173,8 @@ void HTMLLabelElement::DefaultEventHandler(Event* evt) {
.IsRange() &&
!frame->GetEventHandler()
.GetSelectionController()
- .MouseDownWasSingleClickInSelection())
+ .MouseDownWasSingleClickInSelection() &&
+ evt->target()->ToNode()->CanStartSelection())
is_label_text_selected = true;
// If selection is there and is single click i.e. text is
// selected by dragging over label text, then return.
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/label/label-selection-by-textSelection-and-click.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698