third_party/WebKit/Source/core/html/HTMLLabelElement.cpp - Issue 2833313003: Pass clickEvent to controlElement inside label if targetNode can't start selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

Issue 2833313003: Pass clickEvent to controlElement inside label if targetNode can't start selection (Closed)

Patch Set: Address Review Comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

index 06670f2cf1a1c1623ce571f30741bf5481761a0d..7fc8dbe6160768fabf34a48a6ac32b589a756f21 100644

--- a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

@@ -173,7 +173,8 @@ void HTMLLabelElement::DefaultEventHandler(Event* evt) {

.IsRange() &&

!frame->GetEventHandler()

.GetSelectionController()

- .MouseDownWasSingleClickInSelection())

+ .MouseDownWasSingleClickInSelection() &&

+ evt->target()->ToNode()->CanStartSelection())

is_label_text_selected = true;

// If selection is there and is single click i.e. text is

// selected by dragging over label text, then return.