Issue 28333004: Move even more data from .data to .rodata section

Issue 28333004: Move even more data from .data to .rodata section (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium, digit1, eseidel

CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, jamesr, eustas+blink_chromium.org, Rik, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, danakj, darktears, dsinclair, Stephen Chennney, aandrey+blink_chromium.org, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move even more data from .data to .rodata section Move more data from .data to .rodata section so that they can be shared between different library instances on mobile / android. In particular, the following data was moved: - CSSGrammar's star variables - WorkerDebuggerAgent::debuggerTaskMode string - Ranges arrays in Font class This also gets rid of 1 relocation according to relinfo. R=abarth BUG=249746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160203

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	Source/core/css/CSSGrammar.y.in	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/inspector/WorkerDebuggerAgent.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/WorkerDebuggerAgent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/graphics/Font.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/28333004/1

7 years, 2 months ago (2013-10-21 18:58:07 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12837

7 years, 2 months ago (2013-10-22 00:28:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/28333004/1

7 years, 2 months ago (2013-10-22 13:20:24 UTC) #5

Message was sent while issue was closed.

Change committed as 160203

Expand Messages | Collapse Messages