Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 28333003: IDL compiler: [Conditional] for setters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 8d63d0b946603ac7004090d8a26b81b0805ffd17..b059a5d8b52d421d7a29978492e5691b9e3763bc 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -1788,7 +1788,7 @@ sub GenerateNormalAttributeSetterCallback
my $conditionalString = GenerateConditionalString($attribute);
my $code = "";
- $code .= "#if ${conditionalString}\n\n" if $conditionalString;
+ $code .= "#if ${conditionalString}\n" if $conditionalString;
$code .= "static void ${attrName}AttributeSetterCallback${forMainWorldSuffix}(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)\n";
$code .= "{\n";
@@ -1805,8 +1805,9 @@ sub GenerateNormalAttributeSetterCallback
$code .= " ${implClassName}V8Internal::${attrName}AttributeSetter${forMainWorldSuffix}(name, jsValue, info);\n";
}
$code .= " TRACE_EVENT_SET_SAMPLING_STATE(\"V8\", \"Execution\");\n";
- $code .= "}\n\n";
- $code .= "#endif // ${conditionalString}\n\n" if $conditionalString;
+ $code .= "}\n";
+ $code .= "#endif // ${conditionalString}\n" if $conditionalString;
+ $code .= "\n";
$implementation{nameSpaceInternal}->add($code);
}
@@ -1842,7 +1843,7 @@ sub GenerateNormalAttributeSetter
my $conditionalString = GenerateConditionalString($attribute);
my $code = "";
- $code .= "#if ${conditionalString}\n\n" if $conditionalString;
+ $code .= "#if ${conditionalString}\n" if $conditionalString;
$code .= "static void ${attrName}AttributeSetter${forMainWorldSuffix}(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)\n";
$code .= "{\n";
@@ -1912,8 +1913,9 @@ END
$code .= " V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<$mode>, stringResource, jsValue);\n";
# Attr (not Attribute) used in content attributes
$code .= " imp->setAttribute(${namespace}::${contentAttributeName}Attr, stringResource);\n";
- $code .= "}\n\n";
- $code .= "#endif // ${conditionalString}\n\n" if $conditionalString;
+ $code .= "}\n";
+ $code .= "#endif // ${conditionalString}\n" if $conditionalString;
+ $code .= "\n";
$implementation{nameSpaceInternal}->add($code);
return;
# Skip the rest of the function!
@@ -2040,8 +2042,9 @@ END
END
}
- $code .= "}\n\n"; # end of setter
- $code .= "#endif // ${conditionalString}\n\n" if $conditionalString;
+ $code .= "}\n"; # end of setter
+ $code .= "#endif // ${conditionalString}\n" if $conditionalString;
+ $code .= "\n";
$implementation{nameSpaceInternal}->add($code);
}
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698