Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 28333003: IDL compiler: [Conditional] for setters (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [Conditional] for setters Simple change, with some whitespace changes on Perl for consistency and simplicity. BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160004

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -87 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 5 chunks +11 lines, -8 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 6 chunks +0 lines, -22 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 7 chunks +0 lines, -26 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 2 chunks +69 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Nils Barth (inactive)
Quick one.
7 years, 2 months ago (2013-10-18 05:44:04 UTC) #1
haraken
LGTM
7 years, 2 months ago (2013-10-18 05:49:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/28333003/1
7 years, 2 months ago (2013-10-18 06:53:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=9324
7 years, 2 months ago (2013-10-18 18:13:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/28333003/100001
7 years, 2 months ago (2013-10-19 03:03:28 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-19 03:57:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/28333003/100001
7 years, 2 months ago (2013-10-19 04:13:24 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-19 04:42:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/28333003/100001
7 years, 2 months ago (2013-10-19 05:12:18 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-19 05:15:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/28333003/100001
7 years, 2 months ago (2013-10-19 11:07:50 UTC) #11
commit-bot: I haz the power
Failed to apply patch for Source/bindings/tests/idls/TestObjectPython.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-19 11:07:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/28333003/300001
7 years, 2 months ago (2013-10-19 11:12:40 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-19 13:38:07 UTC) #14
Message was sent while issue was closed.
Change committed as 160004

Powered by Google App Engine
This is Rietveld 408576698