Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: base/barrier_closure.h

Issue 2833293004: Adopt base::OnceCallback in base::BarrierClosure (Closed)
Patch Set: update comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/barrier_closure.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/barrier_closure.h
diff --git a/base/barrier_closure.h b/base/barrier_closure.h
index b1204d81465467ae802e066990c745efbfc4c851..282aa39b921813bca02e88d37673ef4907c301c0 100644
--- a/base/barrier_closure.h
+++ b/base/barrier_closure.h
@@ -6,7 +6,7 @@
#define BASE_BARRIER_CLOSURE_H_
#include "base/base_export.h"
-#include "base/callback_forward.h"
+#include "base/callback.h"
namespace base {
@@ -19,11 +19,9 @@ namespace base {
// maintained as a base::AtomicRefCount. |done_closure| will be run on
// the thread that calls the final Run() on the returned closures.
//
-// |done_closure| is also Reset() on the final calling thread but due to the
-// refcounted nature of callbacks, it is hard to know what thread resources
-// will be released on.
-BASE_EXPORT base::Closure BarrierClosure(int num_closures,
- const base::Closure& done_closure);
+// |done_closure| is also cleared on the final calling thread.
+BASE_EXPORT RepeatingClosure BarrierClosure(int num_closures,
+ OnceClosure done_closure);
} // namespace base
« no previous file with comments | « no previous file | base/barrier_closure.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698