Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Side by Side Diff: base/barrier_closure.cc

Issue 2833293004: Adopt base::OnceCallback in base::BarrierClosure (Closed)
Patch Set: update comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/barrier_closure.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/barrier_closure.h" 5 #include "base/barrier_closure.h"
6 6
7 #include <utility>
8
7 #include "base/atomic_ref_count.h" 9 #include "base/atomic_ref_count.h"
8 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/memory/ptr_util.h"
9 12
13 namespace base {
10 namespace { 14 namespace {
11 15
12 // Maintains state for a BarrierClosure. 16 // Maintains state for a BarrierClosure.
13 class BarrierInfo { 17 class BarrierInfo {
14 public: 18 public:
15 BarrierInfo(int num_callbacks_left, const base::Closure& done_closure); 19 BarrierInfo(int num_callbacks_left, OnceClosure done_closure);
16 void Run(); 20 void Run();
17 21
18 private: 22 private:
19 base::AtomicRefCount num_callbacks_left_; 23 AtomicRefCount num_callbacks_left_;
20 base::Closure done_closure_; 24 OnceClosure done_closure_;
21 }; 25 };
22 26
23 BarrierInfo::BarrierInfo(int num_callbacks, const base::Closure& done_closure) 27 BarrierInfo::BarrierInfo(int num_callbacks, OnceClosure done_closure)
24 : num_callbacks_left_(num_callbacks), 28 : num_callbacks_left_(num_callbacks),
25 done_closure_(done_closure) { 29 done_closure_(std::move(done_closure)) {}
26 }
27 30
28 void BarrierInfo::Run() { 31 void BarrierInfo::Run() {
29 DCHECK(!base::AtomicRefCountIsZero(&num_callbacks_left_)); 32 DCHECK(!AtomicRefCountIsZero(&num_callbacks_left_));
30 if (!base::AtomicRefCountDec(&num_callbacks_left_)) { 33 if (!AtomicRefCountDec(&num_callbacks_left_))
31 base::Closure done_closure = done_closure_; 34 std::move(done_closure_).Run();
32 done_closure_.Reset();
33 done_closure.Run();
34 }
35 } 35 }
36 36
37 } // namespace 37 } // namespace
38 38
39 namespace base { 39 RepeatingClosure BarrierClosure(int num_callbacks_left,
40 40 OnceClosure done_closure) {
41 base::Closure BarrierClosure(int num_callbacks_left,
42 const base::Closure& done_closure) {
43 DCHECK_GE(num_callbacks_left, 0); 41 DCHECK_GE(num_callbacks_left, 0);
44 42
45 if (num_callbacks_left == 0) 43 if (num_callbacks_left == 0)
46 done_closure.Run(); 44 std::move(done_closure).Run();
47 45
48 return base::Bind(&BarrierInfo::Run, 46 return BindRepeating(
49 base::Owned( 47 &BarrierInfo::Run,
50 new BarrierInfo(num_callbacks_left, done_closure))); 48 Owned(new BarrierInfo(num_callbacks_left, std::move(done_closure))));
51 } 49 }
52 50
53 } // namespace base 51 } // namespace base
OLDNEW
« no previous file with comments | « base/barrier_closure.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698