Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2833233002: [blink] Perspective layer should be considered fixed-pos container layer (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/transforms/perspective-fixed-pos-descendant-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1595 matching lines...) Expand 10 before | Expand all | Expand 10 after
1606 1606
1607 scrolling_coordinator->UpdateLayerPositionConstraint(&owning_layer_); 1607 scrolling_coordinator->UpdateLayerPositionConstraint(&owning_layer_);
1608 1608
1609 // Page scale is applied as a transform on the root layout view layer. Because 1609 // Page scale is applied as a transform on the root layout view layer. Because
1610 // the scroll layer is further up in the hierarchy, we need to avoid marking 1610 // the scroll layer is further up in the hierarchy, we need to avoid marking
1611 // the root layout view layer as a container. 1611 // the root layout view layer as a container.
1612 bool is_container = 1612 bool is_container =
1613 owning_layer_.GetLayoutObject().CanContainFixedPositionObjects() && 1613 owning_layer_.GetLayoutObject().CanContainFixedPositionObjects() &&
1614 !owning_layer_.IsRootLayer(); 1614 !owning_layer_.IsRootLayer();
1615 scrolling_coordinator->SetLayerIsContainerForFixedPositionLayers( 1615 scrolling_coordinator->SetLayerIsContainerForFixedPositionLayers(
1616 graphics_layer_.get(), is_container); 1616 child_transform_layer_ ? child_transform_layer_.get()
chrishtr 2017/04/24 15:44:22 Add a comment explaining.
1617 : graphics_layer_.get(),
1618 is_container);
1617 } 1619 }
1618 1620
1619 void CompositedLayerMapping::UpdateInternalHierarchy() { 1621 void CompositedLayerMapping::UpdateInternalHierarchy() {
1620 // m_foregroundLayer has to be inserted in the correct order with child 1622 // m_foregroundLayer has to be inserted in the correct order with child
1621 // layers, so it's not inserted here. 1623 // layers, so it's not inserted here.
1622 if (ancestor_clipping_layer_) 1624 if (ancestor_clipping_layer_)
1623 ancestor_clipping_layer_->RemoveAllChildren(); 1625 ancestor_clipping_layer_->RemoveAllChildren();
1624 1626
1625 graphics_layer_->RemoveFromParent(); 1627 graphics_layer_->RemoveFromParent();
1626 1628
(...skipping 1977 matching lines...) Expand 10 before | Expand all | Expand 10 after
3604 } else if (graphics_layer == decoration_outline_layer_.get()) { 3606 } else if (graphics_layer == decoration_outline_layer_.get()) {
3605 name = "Decoration Layer"; 3607 name = "Decoration Layer";
3606 } else { 3608 } else {
3607 NOTREACHED(); 3609 NOTREACHED();
3608 } 3610 }
3609 3611
3610 return name; 3612 return name;
3611 } 3613 }
3612 3614
3613 } // namespace blink 3615 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/transforms/perspective-fixed-pos-descendant-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698