Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: content/public/browser/devtools_manager_delegate.h

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)
Patch Set: cast test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/devtools_agent_host.h ('k') | content/public/browser/devtools_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/devtools_manager_delegate.h
diff --git a/content/public/browser/devtools_manager_delegate.h b/content/public/browser/devtools_manager_delegate.h
index 19c0dbefbb5c568e29a634a0f2a8746ea5f01734..22699ece9f63eaee54999f592789f8f44b02352e 100644
--- a/content/public/browser/devtools_manager_delegate.h
+++ b/content/public/browser/devtools_manager_delegate.h
@@ -35,11 +35,9 @@ class CONTENT_EXPORT DevToolsManagerDelegate {
// Returns DevToolsAgentHost title to use for given |host| target.
virtual std::string GetTargetDescription(RenderFrameHost* host);
- // Returns all targets embedder would like to report as discoverable.
- // If returns false, all targets content is aware of and only those
- // should be discoverable.
- virtual bool DiscoverTargets(
- const DevToolsAgentHost::DiscoveryCallback& callback);
+ // Returns all targets embedder would like to report as debuggable
+ // remotely.
+ virtual DevToolsAgentHost::List RemoteDebuggingTargets();
// Creates new inspectable target given the |url|.
virtual scoped_refptr<DevToolsAgentHost> CreateNewTarget(const GURL& url);
@@ -51,11 +49,9 @@ class CONTENT_EXPORT DevToolsManagerDelegate {
using CommandCallback =
base::Callback<void(std::unique_ptr<base::DictionaryValue> response)>;
- // Handle async command, feed response to CommandCallback when it is ready.
virtual bool HandleAsyncCommand(DevToolsAgentHost* agent_host,
base::DictionaryValue* command,
const CommandCallback& callback);
-
// Should return discovery page HTML that should list available tabs
// and provide attach links.
virtual std::string GetDiscoveryPageHTML();
« no previous file with comments | « content/public/browser/devtools_agent_host.h ('k') | content/public/browser/devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698