Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: content/public/browser/devtools_manager_delegate.cc

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)
Patch Set: cast test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/devtools_manager_delegate.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/devtools_agent_host.h" 5 #include "content/public/browser/devtools_agent_host.h"
6 #include "content/public/browser/devtools_manager_delegate.h" 6 #include "content/public/browser/devtools_manager_delegate.h"
7 7
8 namespace content { 8 namespace content {
9 9
10 void DevToolsManagerDelegate::Inspect(DevToolsAgentHost* agent_host) { 10 void DevToolsManagerDelegate::Inspect(DevToolsAgentHost* agent_host) {
11 } 11 }
12 12
13 std::string DevToolsManagerDelegate::GetTargetType(RenderFrameHost* host) { 13 std::string DevToolsManagerDelegate::GetTargetType(RenderFrameHost* host) {
14 return std::string(); 14 return std::string();
15 } 15 }
16 16
17 std::string DevToolsManagerDelegate::GetTargetTitle(RenderFrameHost* host) { 17 std::string DevToolsManagerDelegate::GetTargetTitle(RenderFrameHost* host) {
18 return std::string(); 18 return std::string();
19 } 19 }
20 20
21 std::string DevToolsManagerDelegate::GetTargetDescription( 21 std::string DevToolsManagerDelegate::GetTargetDescription(
22 RenderFrameHost* host) { 22 RenderFrameHost* host) {
23 return std::string(); 23 return std::string();
24 } 24 }
25 25
26 bool DevToolsManagerDelegate::DiscoverTargets( 26 DevToolsAgentHost::List DevToolsManagerDelegate::RemoteDebuggingTargets() {
27 const DevToolsAgentHost::DiscoveryCallback& callback) { 27 return DevToolsAgentHost::GetOrCreateAll();
28 return false;
29 } 28 }
30 29
31 scoped_refptr<DevToolsAgentHost> DevToolsManagerDelegate::CreateNewTarget( 30 scoped_refptr<DevToolsAgentHost> DevToolsManagerDelegate::CreateNewTarget(
32 const GURL& url) { 31 const GURL& url) {
33 return nullptr; 32 return nullptr;
34 } 33 }
35 34
36 base::DictionaryValue* DevToolsManagerDelegate::HandleCommand( 35 base::DictionaryValue* DevToolsManagerDelegate::HandleCommand(
37 DevToolsAgentHost* agent_host, 36 DevToolsAgentHost* agent_host,
38 base::DictionaryValue* command) { 37 base::DictionaryValue* command) {
(...skipping 13 matching lines...) Expand all
52 51
53 std::string DevToolsManagerDelegate::GetFrontendResource( 52 std::string DevToolsManagerDelegate::GetFrontendResource(
54 const std::string& path) { 53 const std::string& path) {
55 return std::string(); 54 return std::string();
56 } 55 }
57 56
58 DevToolsManagerDelegate::~DevToolsManagerDelegate() { 57 DevToolsManagerDelegate::~DevToolsManagerDelegate() {
59 } 58 }
60 59
61 } // namespace content 60 } // namespace content
OLDNEW
« no previous file with comments | « content/public/browser/devtools_manager_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698