Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/devtools/device/devtools_device_discovery.h

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)
Patch Set: cast test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_DEVICE_DISCOVERY_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_DEVICE_DISCOVERY_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_DEVICE_DISCOVERY_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_DEVICE_DISCOVERY_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 21 matching lines...) Expand all
32 RemotePage(scoped_refptr<AndroidDeviceManager::Device> device, 32 RemotePage(scoped_refptr<AndroidDeviceManager::Device> device,
33 const std::string& browser_id, 33 const std::string& browser_id,
34 const base::DictionaryValue& dict); 34 const base::DictionaryValue& dict);
35 35
36 virtual ~RemotePage(); 36 virtual ~RemotePage();
37 37
38 scoped_refptr<AndroidDeviceManager::Device> device_; 38 scoped_refptr<AndroidDeviceManager::Device> device_;
39 std::string browser_id_; 39 std::string browser_id_;
40 std::string frontend_url_; 40 std::string frontend_url_;
41 std::unique_ptr<base::DictionaryValue> dict_; 41 std::unique_ptr<base::DictionaryValue> dict_;
42 scoped_refptr<content::DevToolsAgentHost> agent_host_;
42 43
43 DISALLOW_COPY_AND_ASSIGN(RemotePage); 44 DISALLOW_COPY_AND_ASSIGN(RemotePage);
44 }; 45 };
45 46
46 using RemotePages = std::vector<scoped_refptr<RemotePage>>; 47 using RemotePages = std::vector<scoped_refptr<RemotePage>>;
47 48
48 class RemoteBrowser : public base::RefCountedThreadSafe<RemoteBrowser> { 49 class RemoteBrowser : public base::RefCountedThreadSafe<RemoteBrowser> {
49 public: 50 public:
50 const std::string& serial() { return serial_; } 51 const std::string& serial() { return serial_; }
51 const std::string& socket() { return browser_id_; } 52 const std::string& socket() { return browser_id_; }
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 136
136 AndroidDeviceManager* device_manager_; 137 AndroidDeviceManager* device_manager_;
137 const DeviceListCallback callback_; 138 const DeviceListCallback callback_;
138 base::Callback<void(const base::Closure&)> task_scheduler_; 139 base::Callback<void(const base::Closure&)> task_scheduler_;
139 base::WeakPtrFactory<DevToolsDeviceDiscovery> weak_factory_; 140 base::WeakPtrFactory<DevToolsDeviceDiscovery> weak_factory_;
140 141
141 DISALLOW_COPY_AND_ASSIGN(DevToolsDeviceDiscovery); 142 DISALLOW_COPY_AND_ASSIGN(DevToolsDeviceDiscovery);
142 }; 143 };
143 144
144 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_DEVICE_DISCOVERY_H_ 145 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_DEVICE_DISCOVERY_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/devtools/device/devtools_device_discovery.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698