DevTools: retain DTAH in all the targets to match their life time.

content/browser/devtools/devtools_agent_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_agent_host_impl.h"
 
 #include <map>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 65 matching lines @@
   for (auto it : result) {
     DevToolsAgentHostImpl* host = static_cast<DevToolsAgentHostImpl*>(it.get());
     DCHECK(g_instances.Get().find(host->id_) != g_instances.Get().end());
   }
 #endif
 
   return result;
 }
 
 // static
-void DevToolsAgentHost::DiscoverAllHosts(const DiscoveryCallback& callback) {
+DevToolsAgentHost::List DevToolsAgentHost::DiscoverAllHosts() {

[dgozman, 2017/04/22 00:00:45]

Inline this method to http handler.

   DevToolsManager* manager = DevToolsManager::GetInstance();
-  if (!manager->delegate() || !manager->delegate()->DiscoverTargets(callback))
-    callback.Run(DevToolsAgentHost::GetOrCreateAll());
+  if (!manager->delegate() || !manager->delegate()->CanDiscoverTargets())
+    return DevToolsAgentHost::GetOrCreateAll();
+  return manager->delegate()->DiscoverTargets();

[dgozman, 2017/04/22 00:00:45]

DiscoverTargetsAvailableRemotely

 }
 
 // Called on the UI thread.
 // static
 scoped_refptr<DevToolsAgentHost> DevToolsAgentHost::GetForWorker(
     int worker_process_id,
     int worker_route_id) {
   if (scoped_refptr<DevToolsAgentHost> host =
       SharedWorkerDevToolsManager::GetInstance()
           ->GetDevToolsAgentHostForWorker(worker_process_id,
@@ skipping 289 matching lines @@
     if (message_buffer_.size() != message_buffer_size_)
       return false;
     callback_.Run(chunk.session_id, message_buffer_);
     message_buffer_ = std::string();
     message_buffer_size_ = 0;
   }
   return true;
 }
 
 }  // namespace content