Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: components/safe_browsing/password_protection/password_protection_service.h

Issue 2833193002: Trigger Password Protection ping on username/password field on focus (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_service.h
diff --git a/components/safe_browsing/password_protection/password_protection_service.h b/components/safe_browsing/password_protection/password_protection_service.h
index 1acf0a4bc50471dc5e19e7c9042aa50fa0f88129..e0470ccaa0daa3139eaf96114533c271ccffa15a 100644
--- a/components/safe_browsing/password_protection/password_protection_service.h
+++ b/components/safe_browsing/password_protection/password_protection_service.h
@@ -32,25 +32,6 @@ namespace safe_browsing {
class SafeBrowsingDatabaseManager;
class PasswordProtectionRequest;
-using PasswordFormList = google::protobuf::RepeatedPtrField<
- LoginReputationClientRequest::Frame::Form>;
-
-// The PasswordProtectionFrame struct encapsulates information about a render
-// frame that has password form(s).
-struct PasswordProtectionFrame {
- int render_frame_routing_id;
- int parent_frame_routing_id;
- GURL last_committed_url;
- std::unique_ptr<PasswordFormList> password_forms;
-
- PasswordProtectionFrame() = delete;
-
- ~PasswordProtectionFrame();
-};
-
-using PasswordProtectionFrameList =
- std::vector<std::unique_ptr<PasswordProtectionFrame>>;
-
// Manage password protection pings and verdicts. There is one instance of this
// class per profile. Therefore, every PasswordProtectionService instance is
// associated with a unique HistoryService instance and a unique
@@ -89,14 +70,15 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
// Creates an instance of PasswordProtectionRequest and call Start() on that
// instance. This function also insert this request object in |requests_| for
// record keeping.
- void StartRequest(
- const GURL& main_frame_url,
- LoginReputationClientRequest::TriggerType type,
- std::unique_ptr<PasswordProtectionFrameList> password_frames);
+ void StartRequest(const GURL& main_frame_url,
+ const GURL& password_form_action,
+ const GURL& password_form_frame_url,
+ LoginReputationClientRequest::TriggerType type);
- void MaybeStartLowReputationRequest(
+ virtual void MaybeStartLowReputationRequest(
const GURL& main_frame_url,
- std::unique_ptr<PasswordProtectionFrameList> password_frames);
+ const GURL& password_form_action,
+ const GURL& password_form_frame_url);
scoped_refptr<SafeBrowsingDatabaseManager> database_manager();

Powered by Google App Engine
This is Rietveld 408576698