Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.h

Issue 2833193002: Trigger Password Protection ping on username/password field on focus (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.h
diff --git a/components/safe_browsing/password_protection/password_protection_request.h b/components/safe_browsing/password_protection/password_protection_request.h
index 81d0c5d2e4f9b0ebf528fdbcfe0c564b37c4f7c4..7eec452eca1aaf4ceca466eadeb25661616fc3c7 100644
--- a/components/safe_browsing/password_protection/password_protection_request.h
+++ b/components/safe_browsing/password_protection/password_protection_request.h
@@ -58,12 +58,12 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
MAX_OUTCOME
};
- PasswordProtectionRequest(
- const GURL& main_frame_url,
- LoginReputationClientRequest::TriggerType type,
- std::unique_ptr<PasswordProtectionFrameList> pending_password_frames,
- PasswordProtectionService* pps,
- int request_timeout_in_ms);
+ PasswordProtectionRequest(const GURL& main_frame_url,
+ const GURL& password_form_action,
+ const GURL& password_form_frame_url,
+ LoginReputationClientRequest::TriggerType type,
+ PasswordProtectionService* pps,
+ int request_timeout_in_ms);
base::WeakPtr<PasswordProtectionRequest> GetWeakPtr() {
return weakptr_factory_.GetWeakPtr();
@@ -119,14 +119,17 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
std::unique_ptr<LoginReputationClientResponse> response);
// Main frame URL of the login form.
- GURL main_frame_url_;
+ const GURL main_frame_url_;
+
+ // The action URL of the password form.
+ const GURL password_form_action_;
+
+ // Frame url of the detected password form.
+ const GURL password_form_frame_url_;
// If this request is for unfamiliar login page or for a password reuse event.
const LoginReputationClientRequest::TriggerType request_type_;
- // The list of PasswordProtectionFrame this request is concerning.
- std::unique_ptr<PasswordProtectionFrameList> password_frames_;
-
// When request is sent.
base::TimeTicks request_start_time_;

Powered by Google App Engine
This is Rietveld 408576698