Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: components/safe_browsing/password_protection/password_protection_service.cc

Issue 2833193002: Trigger Password Protection ping on username/password field on focus (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_service.cc
diff --git a/components/safe_browsing/password_protection/password_protection_service.cc b/components/safe_browsing/password_protection/password_protection_service.cc
index 02c472597d6d09d5644da0f540fa81cc00df7201..2068d4119dcbc2bd24e2fa3aab304bf9bfdc6495 100644
--- a/components/safe_browsing/password_protection/password_protection_service.cc
+++ b/components/safe_browsing/password_protection/password_protection_service.cc
@@ -63,8 +63,6 @@ GURL GetHostNameWithHTTPScheme(const GURL& url) {
} // namespace
-PasswordProtectionFrame::~PasswordProtectionFrame() = default;
-
PasswordProtectionService::PasswordProtectionService(
const scoped_refptr<SafeBrowsingDatabaseManager>& database_manager,
scoped_refptr<net::URLRequestContextGetter> request_context_getter,
@@ -198,13 +196,12 @@ void PasswordProtectionService::CacheVerdict(
void PasswordProtectionService::StartRequest(
const GURL& main_frame_url,
- LoginReputationClientRequest::TriggerType type,
- std::unique_ptr<PasswordProtectionFrameList> password_frames) {
+ const GURL& password_form_action,
+ LoginReputationClientRequest::TriggerType type) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_refptr<PasswordProtectionRequest> request(
- new PasswordProtectionRequest(main_frame_url, type,
- std::move(password_frames), this,
- GetRequestTimeoutInMS()));
+ new PasswordProtectionRequest(main_frame_url, password_form_action, type,
+ this, GetRequestTimeoutInMS()));
DCHECK(request);
request->Start();
requests_.insert(std::move(request));
@@ -212,7 +209,7 @@ void PasswordProtectionService::StartRequest(
void PasswordProtectionService::MaybeStartLowReputationRequest(
const GURL& main_frame_url,
- std::unique_ptr<PasswordProtectionFrameList> password_frames) {
+ const GURL& password_form_action) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (!IsPingingEnabled())
return;
@@ -222,9 +219,8 @@ void PasswordProtectionService::MaybeStartLowReputationRequest(
return;
}
- StartRequest(main_frame_url,
- LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE,
- std::move(password_frames));
+ StartRequest(main_frame_url, password_form_action,
+ LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE);
}
void PasswordProtectionService::RequestFinished(

Powered by Google App Engine
This is Rietveld 408576698