Trigger Password Protection ping on username/password field on focus

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 311 matching lines @@
     GetWebWidget()->Resize(blink::WebSize(500, 500));
     GetWebWidget()->SetFocus(true);
 
     // Now retrieve the input elements so the test can access them.
     UpdateUsernameAndPasswordElements();
   }
 
   void TearDown() override {
     username_element_.Reset();
     password_element_.Reset();
+    dummy_element_.Reset();
     ChromeRenderViewTest::TearDown();
   }
 
   void RegisterMainFrameRemoteInterfaces() override {
     // We only use the fake driver for main frame
     // because our test cases only involve the main frame.
     service_manager::InterfaceProvider* remote_interfaces =
         view_->GetMainRenderFrame()->GetRemoteInterfaces();
     service_manager::InterfaceProvider::TestApi test_api(remote_interfaces);
     test_api.SetBinderForName(
@@ skipping 28 matching lines @@
 
   void UpdateUsernameAndPasswordElements() {
     WebDocument document = GetMainFrame()->GetDocument();
     WebElement element =
         document.GetElementById(WebString::FromUTF8(kUsernameName));
     ASSERT_FALSE(element.IsNull());
     username_element_ = element.To<blink::WebInputElement>();
     element = document.GetElementById(WebString::FromUTF8(kPasswordName));
     ASSERT_FALSE(element.IsNull());
     password_element_ = element.To<blink::WebInputElement>();
+    dummy_element_ = element.To<blink::WebInputElement>();
   }
 
   blink::WebInputElement GetInputElementByID(const std::string& id) {
     WebDocument document = GetMainFrame()->GetDocument();
     WebElement element =
         document.GetElementById(WebString::FromUTF8(id.c_str()));
     return element.To<blink::WebInputElement>();
   }
 
   void ClearUsernameAndPasswordFields() {
     username_element_.SetValue("");
     username_element_.SetAutofilled(false);
     password_element_.SetValue("");
     password_element_.SetAutofilled(false);
+    dummy_element_.SetValue("");
+    dummy_element_.SetAutofilled(false);
   }
 
   void SimulateSuggestionChoice(WebInputElement& username_input) {
     base::string16 username(base::ASCIIToUTF16(kAliceUsername));
     base::string16 password(base::ASCIIToUTF16(kAlicePassword));
     SimulateSuggestionChoiceOfUsernameAndPassword(username_input, username,
                                                   password);
   }
 
   void SimulateSuggestionChoiceOfUsernameAndPassword(
@@ skipping 184 matching lines @@
   base::string16 username2_;
   base::string16 username3_;
   base::string16 password1_;
   base::string16 password2_;
   base::string16 password3_;
   base::string16 alternate_username3_;
   PasswordFormFillData fill_data_;
 
   WebInputElement username_element_;
   WebInputElement password_element_;
+  WebInputElement dummy_element_;

[Mathieu, 2017/05/01 13:40:00]

Could you comment why this is needed? I don't see it referenced from the tests

[Jialiu Lin, 2017/05/01 18:59:09]

Oops, sorry. Forgot to remove this one. 

   base::test::ScopedFeatureList scoped_feature_list_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgentTest);
 };
 
 // Tests that the password login is autocompleted as expected when the browser
 // sends back the password info.
 TEST_F(PasswordAutofillAgentTest, InitialAutocomplete) {
   /*
@@ skipping 2097 matching lines @@
   base::RunLoop().RunUntilIdle();
 
   // Chect that the form was submitted with in-page navigation.
   EXPECT_TRUE(fake_driver_.called_inpage_navigation());
   EXPECT_EQ(base::string16(),
             fake_driver_.password_form_inpage_navigation()->username_value);
   EXPECT_EQ(ASCIIToUTF16("random"),
             fake_driver_.password_form_inpage_navigation()->password_value);
 }
 
+#if defined(SAFE_BROWSING_DB_LOCAL)
+// Verify CheckSafeBrowsingReputation() is called when user start filling

[Mathieu, 2017/05/01 13:40:00]

*starts

[Jialiu Lin, 2017/05/01 18:59:09]

Done

+// username or password field, and this function is only called once.

[Mathieu, 2017/05/01 13:40:00]

*and that this function

[Jialiu Lin, 2017/05/01 18:59:09]

Done

+TEST_F(PasswordAutofillAgentTest,
+       CheckSafeBrowsingReputationWhenUserStartsFillingUsernamePassword) {
+  ASSERT_EQ(0, fake_driver_.called_check_safe_browsing_reputation_cnt());
+  // Simulate a click on password field to set is on focus,

[Mathieu, 2017/05/01 13:40:00]

*to set its focus

[Jialiu Lin, 2017/05/01 18:59:09]

Done

+  // CheckSafeBrowsingReputation() should be called.
+  SimulateElementClick(kPasswordName);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(1, fake_driver_.called_check_safe_browsing_reputation_cnt());
+
+  // Subsequent editing will not trigger CheckSafeBrowsingReputation.
+  SimulatePasswordChange("modify");
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(1, fake_driver_.called_check_safe_browsing_reputation_cnt());
+  SimulateElementClick(kUsernameName);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(1, fake_driver_.called_check_safe_browsing_reputation_cnt());
+
+  // Navigate to another page and click on username field,
+  // CheckSafeBrowsingReputation() should be triggered again.
+  LoadHTML(kFormHTML);
+  SimulateElementClick(kUsernameName);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(2, fake_driver_.called_check_safe_browsing_reputation_cnt());
+}
+

[Mathieu, 2017/05/01 13:40:00]

nit: remove extra line

[Jialiu Lin, 2017/05/01 18:59:09]

Done.

+#endif
 }  // namespace autofill