Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2741)

Unified Diff: ash/shelf/shelf_controller.cc

Issue 2833173002: mash: Support ShelfModel access in Chrome. (Closed)
Patch Set: Address comments; fix test failures. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_controller.cc
diff --git a/ash/shelf/shelf_controller.cc b/ash/shelf/shelf_controller.cc
index fda06758725b9c591c8fa33b4f8876a8292031ec..4b51989ebf6f3d4ddf87e98c4142e67d966df75d 100644
--- a/ash/shelf/shelf_controller.cc
+++ b/ash/shelf/shelf_controller.cc
@@ -4,12 +4,14 @@
#include "ash/shelf/shelf_controller.h"
-#include "ash/public/interfaces/shelf.mojom.h"
+#include "ash/public/cpp/config.h"
+#include "ash/public/cpp/remote_shelf_item_delegate.h"
#include "ash/root_window_controller.h"
#include "ash/session/session_controller.h"
#include "ash/shelf/app_list_shelf_item_delegate.h"
#include "ash/shelf/shelf.h"
#include "ash/shell.h"
+#include "base/auto_reset.h"
#include "base/strings/utf_string_conversions.h"
#include "ui/base/models/simple_menu_model.h"
#include "ui/display/display.h"
@@ -30,11 +32,15 @@ Shelf* GetShelfForDisplay(int64_t display_id) {
} // namespace
ShelfController::ShelfController() {
- // Create the app list item in the shelf.
- AppListShelfItemDelegate::CreateAppListItemAndDelegate(&model_);
+ // Create an AppListShelfItemDelegate for the app list item.
+ model_.SetShelfItemDelegate(ShelfID(kAppListId),
+ base::MakeUnique<AppListShelfItemDelegate>());
+ model_.AddObserver(this);
}
-ShelfController::~ShelfController() {}
+ShelfController::~ShelfController() {
+ model_.RemoveObserver(this);
+}
void ShelfController::BindRequest(mojom::ShelfControllerRequest request) {
bindings_.AddBinding(this, std::move(request));
@@ -75,6 +81,22 @@ void ShelfController::AddObserver(
mojom::ShelfObserverAssociatedPtrInfo observer) {
mojom::ShelfObserverAssociatedPtr observer_ptr;
observer_ptr.Bind(std::move(observer));
+
+ if (Shell::GetAshConfig() == Config::MASH) {
+ // Mash synchronizes two ShelfModel instances, owned by Ash and Chrome.
+ // Notify Chrome of existing ShelfModel items created by Ash.
+ for (int i = 0; i < model_.item_count(); ++i) {
+ const ShelfItem& item = model_.items()[i];
+ observer_ptr->OnShelfItemAdded(i, item);
+ ShelfItemDelegate* delegate = model_.GetShelfItemDelegate(item.id);
+ mojom::ShelfItemDelegatePtr delegate_ptr;
+ if (delegate)
+ delegate_ptr = delegate->CreateInterfacePtrAndBind();
+ observer_ptr->OnShelfItemDelegateChanged(item.id,
+ std::move(delegate_ptr));
+ }
+ }
+
observers_.AddPtr(std::move(observer_ptr));
}
@@ -98,19 +120,130 @@ void ShelfController::SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide,
shelf->SetAutoHideBehavior(auto_hide);
}
-void ShelfController::PinItem(
- const ShelfItem& item,
- mojom::ShelfItemDelegateAssociatedPtrInfo delegate) {
- NOTIMPLEMENTED();
+void ShelfController::AddShelfItem(int32_t index, const ShelfItem& item) {
+ DCHECK_EQ(Shell::GetAshConfig(), Config::MASH) << "Unexpected model sync";
+ DCHECK(!applying_remote_shelf_model_changes_) << "Unexpected model change";
+ index = index < 0 ? model_.item_count() : index;
+ DCHECK_GT(index, 0) << "Items can not preceed the AppList";
+ DCHECK_LE(index, model_.item_count()) << "Index out of bounds";
+ index = std::min(std::max(index, 1), model_.item_count());
+ base::AutoReset<bool> reset(&applying_remote_shelf_model_changes_, true);
+ model_.AddAt(index, item);
+}
+
+void ShelfController::RemoveShelfItem(const ShelfID& id) {
+ DCHECK_EQ(Shell::GetAshConfig(), Config::MASH) << "Unexpected model sync";
+ DCHECK(!applying_remote_shelf_model_changes_) << "Unexpected model change";
+ const int index = model_.ItemIndexByID(id);
+ DCHECK_GE(index, 0) << "Item not found";
+ DCHECK_NE(index, 0) << "The AppList shelf item cannot be removed";
+ if (index <= 0)
+ return;
+ base::AutoReset<bool> reset(&applying_remote_shelf_model_changes_, true);
+ model_.RemoveItemAt(index);
+}
+
+void ShelfController::MoveShelfItem(const ShelfID& id, int32_t index) {
+ DCHECK_EQ(Shell::GetAshConfig(), Config::MASH) << "Unexpected model sync";
+ DCHECK(!applying_remote_shelf_model_changes_) << "Unexpected model change";
+ const int current_index = model_.ItemIndexByID(id);
+ DCHECK_GE(current_index, 0) << "No item found with the given id";
+ DCHECK_NE(current_index, 0) << "The AppList shelf item cannot be moved";
+ if (current_index <= 0)
+ return;
+ DCHECK_GT(index, 0) << "Items can not preceed the AppList";
+ DCHECK_LT(index, model_.item_count()) << "Index out of bounds";
+ index = std::min(std::max(index, 1), model_.item_count() - 1);
+ DCHECK_NE(current_index, index) << "The item is already at the given index";
+ if (current_index == index)
+ return;
+ base::AutoReset<bool> reset(&applying_remote_shelf_model_changes_, true);
+ model_.Move(current_index, index);
+}
+
+void ShelfController::UpdateShelfItem(const ShelfItem& item) {
+ DCHECK_EQ(Shell::GetAshConfig(), Config::MASH) << "Unexpected model sync";
+ DCHECK(!applying_remote_shelf_model_changes_) << "Unexpected model change";
+ const int index = model_.ItemIndexByID(item.id);
+ DCHECK_GE(index, 0) << "No item found with the given id";
+ if (index < 0)
+ return;
+ base::AutoReset<bool> reset(&applying_remote_shelf_model_changes_, true);
+ model_.Set(index, item);
+}
+
+void ShelfController::SetShelfItemDelegate(
+ const ShelfID& id,
+ mojom::ShelfItemDelegatePtr delegate) {
+ DCHECK_EQ(Shell::GetAshConfig(), Config::MASH) << "Unexpected model sync";
+ DCHECK(!applying_remote_shelf_model_changes_) << "Unexpected model change";
+ base::AutoReset<bool> reset(&applying_remote_shelf_model_changes_, true);
+ if (delegate.is_bound())
+ model_.SetShelfItemDelegate(
+ id, base::MakeUnique<RemoteShelfItemDelegate>(id, std::move(delegate)));
+ else
+ model_.SetShelfItemDelegate(id, nullptr);
+}
+
+void ShelfController::ShelfItemAdded(int index) {
+ if (applying_remote_shelf_model_changes_ ||
+ Shell::GetAshConfig() != Config::MASH) {
+ return;
+ }
+
+ const ShelfItem& item = model_.items()[index];
+ observers_.ForAllPtrs([index, item](mojom::ShelfObserver* observer) {
+ observer->OnShelfItemAdded(index, item);
+ });
}
-void ShelfController::UnpinItem(const std::string& app_id) {
- NOTIMPLEMENTED();
+void ShelfController::ShelfItemRemoved(int index, const ShelfItem& old_item) {
+ if (applying_remote_shelf_model_changes_ ||
+ Shell::GetAshConfig() != Config::MASH) {
+ return;
+ }
+
+ observers_.ForAllPtrs([old_item](mojom::ShelfObserver* observer) {
+ observer->OnShelfItemRemoved(old_item.id);
+ });
}
-void ShelfController::SetItemImage(const std::string& app_id,
- const SkBitmap& image) {
- NOTIMPLEMENTED();
+void ShelfController::ShelfItemMoved(int start_index, int target_index) {
+ if (applying_remote_shelf_model_changes_ ||
+ Shell::GetAshConfig() != Config::MASH) {
+ return;
+ }
+
+ const ShelfItem& item = model_.items()[target_index];
+ observers_.ForAllPtrs([item, target_index](mojom::ShelfObserver* observer) {
+ observer->OnShelfItemMoved(item.id, target_index);
+ });
+}
+
+void ShelfController::ShelfItemChanged(int index, const ShelfItem& old_item) {
+ if (applying_remote_shelf_model_changes_ ||
+ Shell::GetAshConfig() != Config::MASH) {
+ return;
+ }
+
+ const ShelfItem& item = model_.items()[index];
+ observers_.ForAllPtrs([item](mojom::ShelfObserver* observer) {
+ observer->OnShelfItemUpdated(item);
+ });
+}
+
+void ShelfController::ShelfItemDelegateChanged(const ShelfID& id,
+ ShelfItemDelegate* delegate) {
+ if (applying_remote_shelf_model_changes_ ||
+ Shell::GetAshConfig() != Config::MASH) {
+ return;
+ }
+
+ observers_.ForAllPtrs([id, delegate](mojom::ShelfObserver* observer) {
+ observer->OnShelfItemDelegateChanged(
+ id, delegate ? delegate->CreateInterfacePtrAndBind()
+ : mojom::ShelfItemDelegatePtr());
+ });
}
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698