Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: ui/base/cursor/ozone/cursor_data_factory_ozone.cc

Issue 2833163002: Change ui cursor identifiers to an enum class. (Closed)
Patch Set: OK, it can't be explicit for mac. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/cursor/ozone/cursor_data_factory_ozone.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/cursor/ozone/cursor_data_factory_ozone.cc
diff --git a/ui/base/cursor/ozone/cursor_data_factory_ozone.cc b/ui/base/cursor/ozone/cursor_data_factory_ozone.cc
index 7d900d4b89fc7e44d1ee542c4654273cec6d9a5d..e0a68d956ad4c99a1129dc4cc282aab917f8fc63 100644
--- a/ui/base/cursor/ozone/cursor_data_factory_ozone.cc
+++ b/ui/base/cursor/ozone/cursor_data_factory_ozone.cc
@@ -50,7 +50,7 @@ const ui::CursorData& CursorDataFactoryOzone::GetCursorData(
return ToCursorDataOzone(platform_cursor)->data();
}
-PlatformCursor CursorDataFactoryOzone::GetDefaultCursor(int type) {
+PlatformCursor CursorDataFactoryOzone::GetDefaultCursor(CursorType type) {
// Unlike BitmapCursorFactoryOzone, we aren't making heavyweight bitmaps, but
// we still have to cache these forever because objects that come out of the
// GetDefaultCursor() method aren't treated as refcounted by the ozone
@@ -89,8 +89,8 @@ void CursorDataFactoryOzone::UnrefImageCursor(PlatformCursor cursor) {
}
scoped_refptr<CursorDataOzone> CursorDataFactoryOzone::GetDefaultCursorInternal(
- int type) {
- if (type == kCursorNone)
+ CursorType type) {
+ if (type == CursorType::kNone)
return nullptr; // nullptr is used for hidden cursor.
if (!default_cursors_.count(type)) {
« no previous file with comments | « ui/base/cursor/ozone/cursor_data_factory_ozone.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698