Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: ash/wm/window_manager_unittest.cc

Issue 2833163002: Change ui cursor identifiers to an enum class. (Closed)
Patch Set: Remove extranious ::ui:: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_manager_unittest.cc
diff --git a/ash/wm/window_manager_unittest.cc b/ash/wm/window_manager_unittest.cc
index 69647c37d7ca436e5841030e28f0df26cc2fa5aa..bc6772f135ed5e22959153bc1b8e3df659e5d226 100644
--- a/ash/wm/window_manager_unittest.cc
+++ b/ash/wm/window_manager_unittest.cc
@@ -492,7 +492,7 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventSink* sink = host->event_sink();
// Cursor starts as a pointer (set during Shell::Init()).
- EXPECT_EQ(ui::kCursorPointer, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::POINTER, host->last_cursor().native_type());
{
// Resize edges and corners show proper cursors.
@@ -501,7 +501,7 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move1);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorSouthResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::SOUTH_RESIZE, host->last_cursor().native_type());
}
{
@@ -510,7 +510,8 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move2);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorSouthWestResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::SOUTH_WEST_RESIZE,
+ host->last_cursor().native_type());
}
{
@@ -519,7 +520,8 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move1);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorSouthEastResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::SOUTH_EAST_RESIZE,
+ host->last_cursor().native_type());
}
{
@@ -528,7 +530,7 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move2);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorWestResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::WEST_RESIZE, host->last_cursor().native_type());
}
{
@@ -537,7 +539,7 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move1);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorEastResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::EAST_RESIZE, host->last_cursor().native_type());
}
{
@@ -546,7 +548,7 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move2);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorNorthResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::NORTH_RESIZE, host->last_cursor().native_type());
}
{
@@ -555,7 +557,8 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move1);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorNorthWestResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::NORTH_WEST_RESIZE,
+ host->last_cursor().native_type());
}
{
@@ -564,7 +567,8 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move2);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorNorthEastResize, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::NORTH_EAST_RESIZE,
+ host->last_cursor().native_type());
}
{
@@ -574,7 +578,7 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
ui::EventTimeForNow(), 0, 0);
ui::EventDispatchDetails details = sink->OnEventFromSource(&move1);
ASSERT_FALSE(details.dispatcher_destroyed);
- EXPECT_EQ(ui::kCursorNull, host->last_cursor().native_type());
+ EXPECT_EQ(ui::CursorType::CURSOR_NULL, host->last_cursor().native_type());
}
}

Powered by Google App Engine
This is Rietveld 408576698