Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2833153002: Restore ??= for the timer in file state. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore ??= for the timer in file state. The issue that forced us to use the explicit if-statement was fixed. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c2dac3786d76c96b4f7bdbf0abdd10954862cf16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-21 17:09:21 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-21 17:36:22 UTC) #2
scheglov
3 years, 8 months ago (2017-04-21 17:44:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c2dac3786d76c96b4f7bdbf0abdd10954862cf16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698