Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: ui/views/animation/ink_drop_host_view.cc

Issue 2833133003: views: disable ink drops altogether on Mac (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/button/checkbox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/animation/ink_drop_host_view.cc
diff --git a/ui/views/animation/ink_drop_host_view.cc b/ui/views/animation/ink_drop_host_view.cc
index 5cdaedba6c9c7737aa1ffcf71cddc474326a5dcf..f204e80b9d6cac022a25a1a6f7825eb2c0f1e810 100644
--- a/ui/views/animation/ink_drop_host_view.cc
+++ b/ui/views/animation/ink_drop_host_view.cc
@@ -15,6 +15,7 @@
#include "ui/views/animation/ink_drop_mask.h"
#include "ui/views/animation/ink_drop_stub.h"
#include "ui/views/animation/square_ink_drop_ripple.h"
+#include "ui/views/style/platform_style.h"
namespace views {
namespace {
@@ -202,6 +203,10 @@ gfx::Point InkDropHostView::GetInkDropCenterBasedOnLastEvent() const {
void InkDropHostView::AnimateInkDrop(InkDropState state,
const ui::LocatedEvent* event) {
+ // On Mac, ink drops are never used: https://crbug.com/701888
+ if (!PlatformStyle::kUseRipples)
+ return;
+
#if defined(OS_WIN)
// On Windows, don't initiate ink-drops for touch/gesture events.
// Additionally, certain event states should dismiss existing ink-drop
« no previous file with comments | « no previous file | ui/views/controls/button/checkbox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698