Ensure that any IPC sent from a child process that couldn't be deserialized causes that p…

content/browser/browser_child_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_child_process_host_impl.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "content/browser/histogram_message_filter.h"
 #include "content/browser/loader/resource_message_filter.h"
 #include "content/browser/profiler_message_filter.h"
 #include "content/browser/tracing/trace_message_filter.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/public/browser/browser_child_process_host_delegate.h"
 #include "content/public/browser/browser_child_process_observer.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/content_browser_client.h"
+#include "content/public/browser/user_metrics.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/process_type.h"
 #include "content/public/common/result_codes.h"
 
 #if defined(OS_MACOSX)
 #include "content/browser/mach_broker_mac.h"
 #endif
 
 namespace content {
 namespace {
@@ skipping 207 matching lines @@
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
                           base::Bind(&NotifyProcessHostConnected, data_));
 
   delegate_->OnChannelConnected(peer_pid);
 }
 
 void BrowserChildProcessHostImpl::OnChannelError() {
   delegate_->OnChannelError();
 }
 
+void BrowserChildProcessHostImpl::OnBadMessageReceived(
+    const IPC::Message& message) {
+  std::string action_name = std::string("BadMessageTerminate_") +
+                            GetProcessTypeNameInEnglish(data_.process_type);
+  // The English name of a process type sometimes has spaces. Remove them since

[Tom Sepez, 2014/05/15 19:57:42]

Maybe we want to add GetProcessTypeNameForUMA() rather than mucking about with
the syntax here.  Later on, someone may add other funny characters other than
spaces when they create a new process type.

[jam, 2014/05/15 21:19:34]

i prefer not adding yet another way of getting a name unless i know for sure we
need it. i'm not sure what you mean by funny chars, so let's consider that later
if it happens

+  // UMA action names don't contain whitespaces.
+  base::RemoveChars(action_name, " ", &action_name);
+  RecordAction(base::UserMetricsAction(action_name.c_str()));
+  base::KillProcess(GetHandle(), RESULT_CODE_KILLED_BAD_MESSAGE, false);
+}
+
 bool BrowserChildProcessHostImpl::CanShutdown() {
   return delegate_->CanShutdown();
 }
 
 void BrowserChildProcessHostImpl::OnChildDisconnected() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (child_process_.get() || data_.handle) {
     DCHECK(data_.handle != base::kNullProcessHandle);
     int exit_code;
     base::TerminationStatus status = GetTerminationStatus(
@@ skipping 82 matching lines @@
 
 void BrowserChildProcessHostImpl::OnProcessExitedEarly(
     base::WaitableEvent* event) {
   DeleteProcessWaitableEvent(event);
   OnChildDisconnected();
 }
 
 #endif
 
 }  // namespace content