Issue 2833013: Tweaks for the merged menu:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2833013: Tweaks for the merged menu: (Closed)

Created:
10 years, 6 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews

Visibility:
Public.

Description

Tweaks for the merged menu: . makes the menu show the same fonts regardless of whether the item has children. . adds text color to MenuConfig. I'm going to use this for the buttons added to the menu. . Changes TextButton to update text_size_ when the font changes. . Changes TextButton to allow you to specify how accelerators are shown. . Nukes TextButton::OnMousePressed as it's not needed (super implementation does the right thing and updates state the TextButton::OnMousePressed wasn't). . Changes accelerator to have constructor taking keycode and modifiers. BUG=45734 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50108

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -31 lines)			Patch
M	app/menus/accelerator.h	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	views/accelerator.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	views/controls/button/text_button.h	View	6 chunks	+22 lines, -2 lines	0 comments	Download
M	views/controls/button/text_button.cc	View	10 chunks	+37 lines, -15 lines	0 comments	Download
M	views/controls/menu/menu_config.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	views/controls/menu/menu_config_gtk.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_config_win.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_item_view_gtk.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	views/controls/menu/menu_item_view_win.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages