Index: headless/lib/headless_browser_browsertest.cc |
diff --git a/headless/lib/headless_browser_browsertest.cc b/headless/lib/headless_browser_browsertest.cc |
index 52931af4ab572171d84414386a5db3452cdde53e..0d82a0d98510ece22e44a8e4d26c68ff2e2a55a5 100644 |
--- a/headless/lib/headless_browser_browsertest.cc |
+++ b/headless/lib/headless_browser_browsertest.cc |
@@ -400,7 +400,7 @@ |
class ProtocolHandlerWithCookies |
: public net::URLRequestJobFactory::ProtocolHandler { |
public: |
- ProtocolHandlerWithCookies(net::CookieList* sent_cookies); |
+ explicit ProtocolHandlerWithCookies(net::CookieList* sent_cookies); |
~ProtocolHandlerWithCookies() override {} |
net::URLRequestJob* MaybeCreateJob( |
@@ -634,11 +634,7 @@ |
// TODO(skyostil): This test currently relies on being able to run a shell |
// script. |
#if defined(OS_POSIX) |
-#define MAYBE_RendererCommandPrefixTest RendererCommandPrefixTest |
-#else |
-#define MAYBE_RendererCommandPrefixTest DISABLED_RendererCommandPrefixTest |
-#endif // defined(OS_POSIX) |
-IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, MAYBE_RendererCommandPrefixTest) { |
+IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, RendererCommandPrefixTest) { |
base::ThreadRestrictions::SetIOAllowed(true); |
base::FilePath launcher_stamp; |
base::CreateTemporaryFile(&launcher_stamp); |
@@ -676,6 +672,7 @@ |
base::DeleteFile(launcher_script, false); |
base::DeleteFile(launcher_stamp, false); |
} |
+#endif // defined(OS_POSIX) |
class CrashReporterTest : public HeadlessBrowserTest, |
public HeadlessWebContents::Observer, |
@@ -686,7 +683,8 @@ |
void SetUp() override { |
base::ThreadRestrictions::SetIOAllowed(true); |
- base::CreateNewTempDirectory("CrashReporterTest", &crash_dumps_dir_); |
+ base::CreateNewTempDirectory(FILE_PATH_LITERAL("CrashReporterTest"), |
+ &crash_dumps_dir_); |
EXPECT_FALSE(options()->enable_crash_reporter); |
options()->enable_crash_reporter = true; |
options()->crash_dumps_dir = crash_dumps_dir_; |
@@ -749,7 +747,7 @@ |
base::FileEnumerator::FILES); |
base::FilePath minidump = it.Next(); |
EXPECT_FALSE(minidump.empty()); |
- EXPECT_EQ(".dmp", minidump.Extension()); |
+ EXPECT_EQ(FILE_PATH_LITERAL(".dmp"), minidump.Extension()); |
EXPECT_TRUE(it.Next().empty()); |
} |