Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2832943002: DevTools: properly handle target suspension/resuming in NetworkProject (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
index 699286ccf95613febd9ce5a0e3aa9a9d034a38ba..a3f59f1072088747f07a7b7b362046351bf01561 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
@@ -28,19 +28,24 @@ SDK.TargetManager = class extends Common.Object {
this._webSocketConnectionLostCallback;
}
+ /**
+ * @return {!Promise}
+ */
suspendAllTargets() {
if (this._isSuspended)
- return;
+ return Promise.resolve();
this._isSuspended = true;
this.dispatchEventToListeners(SDK.TargetManager.Events.SuspendStateChanged);
+ var promises = [];
for (var target of this._targets) {
var childTargetManager = this._childTargetManagers.get(target);
if (childTargetManager)
- childTargetManager.suspend();
+ promises.push(childTargetManager.suspend());
for (var model of target.models().values())
- model.suspendModel();
+ promises.push(model.suspendModel());
}
+ return Promise.all(promises);
}
/**
@@ -48,7 +53,7 @@ SDK.TargetManager = class extends Common.Object {
*/
resumeAllTargets() {
if (!this._isSuspended)
- throw new Error('Not suspended');
+ return Promise.resolve();
this._isSuspended = false;
this.dispatchEventToListeners(SDK.TargetManager.Events.SuspendStateChanged);
@@ -411,8 +416,11 @@ SDK.ChildTargetManager = class {
}
}
+ /**
+ * @return {!Promise}
+ */
suspend() {
- this._targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: false});
+ return this._targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: false});
}
/**
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698