DevTools: properly handle target suspension/resuming in NetworkProject

third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 SDK.TargetManager = class extends Common.Object {
   constructor() {
     super();
     /** @type {!Array.<!SDK.Target>} */
@@ skipping 10 matching lines @@
     /** @type {!Map<!SDK.Target, !SDK.ChildTargetManager>} */
     this._childTargetManagers = new Map();
     /** @type {!Set<string>} */
     this._nodeTargetIds = new Set();
     /** @type {!Protocol.InspectorBackend.Connection} */
     this._mainConnection;
     /** @type {function()} */
     this._webSocketConnectionLostCallback;
   }
 
+  /**
+   * @return {!Promise}
+   */
   suspendAllTargets() {
     if (this._isSuspended)
-      return;
+      throw new Error('Already suspended');

[dgozman, 2017/05/05 06:10:55]

Not sure this won't ever happen. Let's just return Promise.resolve.

[lushnikov, 2017/05/05 20:58:26]

Changed both here and in resumeAllTargets() to make them symmetrical. Done.

     this._isSuspended = true;
     this.dispatchEventToListeners(SDK.TargetManager.Events.SuspendStateChanged);
 
+    var promises = [];
     for (var target of this._targets) {
       var childTargetManager = this._childTargetManagers.get(target);
       if (childTargetManager)
-        childTargetManager.suspend();
+        promises.push(childTargetManager.suspend());
       for (var model of target.models().values())
-        model.suspendModel();
+        promises.push(model.suspendModel());
     }
+    return Promise.all(promises);
   }
 
   /**
    * @return {!Promise}
    */
   resumeAllTargets() {
     if (!this._isSuspended)
       throw new Error('Not suspended');
     this._isSuspended = false;
     this.dispatchEventToListeners(SDK.TargetManager.Events.SuspendStateChanged);
@@ skipping 350 matching lines @@
     this._targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: true});
     if (Runtime.experiments.isEnabled('autoAttachToCrossProcessSubframes'))
       this._targetAgent.setAttachToFrames(true);
 
     if (!parentTarget.parentTarget()) {
       this._targetAgent.setRemoteLocations([{host: 'localhost', port: 9229}]);
       this._targetAgent.setDiscoverTargets(true);
     }
   }
 
+  /**
+   * @return {!Promise}
+   */
   suspend() {
-    this._targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: false});
+    return this._targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: false});
   }
 
   /**
    * @return {!Promise}
    */
   resume() {
     return this._targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: true});
   }
 
   dispose() {
@@ skipping 184 matching lines @@
   /**
    * @param {!T} model
    */
   modelRemoved(model) {},
 };
 
 /**
  * @type {!SDK.TargetManager}
  */
 SDK.targetManager = new SDK.TargetManager();