Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2832923003: v8binding: Don't allow author script to define indexed accessor prop. (Closed)
Patch Set: Added the test expectation. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/Window.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
index 0f86edb56fcbb62dce08d3c0196b7d3070752a3e..6d83f2a337eea40f6d281d3bd875d1df056d5b6a 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
@@ -118,18 +118,6 @@ DOMWindow* DOMWindow::AnonymousIndexedGetter(uint32_t index) const {
return child ? child->DomWindow() : nullptr;
}
-bool DOMWindow::AnonymousIndexedSetter(uint32_t index,
- const ScriptValue& value) {
- // https://html.spec.whatwg.org/C/browsers.html#windowproxy-defineownproperty
- // step 2 - 1. If P is an array index property name, return false.
- //
- // As an alternative way to implement WindowProxy.[[DefineOwnProperty]] for
- // array index property names, we always intercept and ignore the set
- // operation for indexed properties, i.e. [[DefineOwnProperty]] for array
- // index property names has always no effect.
- return true; // Intercept unconditionally but do nothing.
-}
-
bool DOMWindow::IsCurrentlyDisplayedInFrame() const {
if (GetFrame())
SECURITY_CHECK(GetFrame()->DomWindow() == this);
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/Window.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698