third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp - Issue 2832923003: v8binding: Don't allow author script to define indexed accessor prop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

Issue 2832923003: v8binding: Don't allow author script to define indexed accessor prop. (Closed)

Patch Set: Added the test expectation. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

index 99da49e77cf13e2bc78ea6d0f5471ca8dca1d9ad..5dd7fff6d14a4d4045d8cd1af71a3cc1c5f53e10 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

@@ -206,7 +206,15 @@ static void installV8TestSpecialOperationsTemplate(

signature, V8TestSpecialOperationsMethods, WTF_ARRAY_LENGTH(V8TestSpecialOperationsMethods));

// Indexed properties

- v8::IndexedPropertyHandlerConfiguration indexedPropertyHandlerConfig(V8TestSpecialOperations::indexedPropertyGetterCallback, V8TestSpecialOperations::indexedPropertySetterCallback, nullptr, nullptr, nullptr, v8::Local<v8::Value>(), v8::PropertyHandlerFlags::kNone);

+ v8::IndexedPropertyHandlerConfiguration indexedPropertyHandlerConfig(

+ V8TestSpecialOperations::indexedPropertyGetterCallback,

+ V8TestSpecialOperations::indexedPropertySetterCallback,

+ nullptr,

+ v8::Local<v8::Value>(),

+ v8::PropertyHandlerFlags::kNone);

instanceTemplate->SetHandler(indexedPropertyHandlerConfig);

// Named properties

v8::NamedPropertyHandlerConfiguration namedPropertyHandlerConfig(V8TestSpecialOperations::namedPropertyGetterCallback, V8TestSpecialOperations::namedPropertySetterCallback, V8TestSpecialOperations::namedPropertyQueryCallback, nullptr, V8TestSpecialOperations::namedPropertyEnumeratorCallback, v8::Local<v8::Value>(), static_cast<v8::PropertyHandlerFlags>(int(v8::PropertyHandlerFlags::kOnlyInterceptStrings)));