Harmonizing SmartLock dialog

chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
@@ skipping 452 matching lines @@
   // Successful login with the same form after block will prompt:
   blocked_form.reset(new autofill::PasswordForm(form));
   client()->NotifyUserCouldBeAutoSignedIn(std::move(blocked_form));
   client()->NotifySuccessfulLoginWithExistingPassword(form);
   ASSERT_TRUE(controller()->current_autosignin_prompt());
 }
 
 // DialogBrowserTest methods for interactive dialog invocation.
 void PasswordDialogViewTest::ShowDialog(const std::string& name) {
   GURL origin("https://example.com");
-  EXPECT_EQ("PopupAutoSigninPrompt", name);
   std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials;
   autofill::PasswordForm form;
   form.origin = origin;
   form.display_name = base::ASCIIToUTF16("Peter");
   form.username_value = base::ASCIIToUTF16("peter@pan.test");
-  form.icon_url = GURL("broken url");
-  local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
-  GURL icon_url("https://google.com/icon.png");
-  form.icon_url = icon_url;
-  form.display_name = base::ASCIIToUTF16("Peter Pan");
-  form.federation_origin = url::Origin(GURL("https://google.com/federation"));
-  local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
-  SetupChooseCredentials(std::move(local_credentials), origin);
-  ASSERT_TRUE(controller()->current_account_chooser());
+  if (name == "PopupAutoSigninPrompt") {
+    form.icon_url = GURL("broken url");
+    local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
+    GURL icon_url("https://google.com/icon.png");

[Peter Kasting, 2017/04/24 22:48:31]

Nit: Inline into next line

[kylix_rd, 2017/04/25 17:14:07]

Done.

+    form.icon_url = icon_url;
+    form.display_name = base::ASCIIToUTF16("Peter Pan");
+    form.federation_origin = url::Origin(GURL("https://google.com/federation"));
+    local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
+    SetupChooseCredentials(std::move(local_credentials), origin);
+    ASSERT_TRUE(controller()->current_account_chooser());
+  } else if (name == "PopupAccountChooserWithSingleCredentialClickSignIn") {
+    local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
+    SetupChooseCredentials(std::move(local_credentials), origin);
+  } else {
+    ADD_FAILURE() << "Unknown dialog type";
+    return;
+  }
 }
 
 IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,
                        InvokeDialog_PopupAutoSigninPrompt) {
   RunDialog();
 }
 
+IN_PROC_BROWSER_TEST_F(
+    PasswordDialogViewTest,
+    InvokeDialog_PopupAccountChooserWithSingleCredentialClickSignIn) {
+  RunDialog();
+}
+
 }  // namespace