Issue 2832893002: Issue 29398. Infer instance members using InheritanceManager of the ClassElement.

Issue 2832893002: Issue 29398. Infer instance members using InheritanceManager of the ClassElement. (Closed)

Created:
3 years, 8 months ago by scheglov

Modified:
3 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 29398. Infer instance members using InheritanceManager of the ClassElement. One of the other possible solutions is to put InheritanceManager accessor into LibraryElement, just like LibraryElementInBuildUnit does. But at the end I decided against it. Libraries are not immutable, we still have vestiges of incremental analysis in the codebase. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/29398 Committed: https://github.com/dart-lang/sdk/commit/ddf683c73290e32fc846aa28c3c0b211540a3624

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -20 lines)			Patch
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/summary/link.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/strong_mode.dart	View	10 chunks	+29 lines, -12 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/top_level_inference_test.dart	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/strong_mode_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 8 months ago (2017-04-20 19:04:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ddf683c73290e32fc846aa28c3c0b211540a3624 (presubmit successful).