Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

Issue 2832883003: Remove unneeded Convert* methods and move many from FrameViewBase to FrameView (Closed)
Patch Set: remove scrollbar convert methods Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
index ec956d704c42703e51975686b523788e74b96243..d83d0c94409a9b817ddca2efdbb1bdf3154d0e8a 100644
--- a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
+++ b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
@@ -569,44 +569,17 @@ bool Scrollbar::IsWindowActive() const {
return scrollable_area_ && scrollable_area_->IsActive();
}
-IntRect Scrollbar::ConvertToContainingFrameViewBase(
- const IntRect& local_rect) const {
- if (scrollable_area_) {
- return scrollable_area_->ConvertFromScrollbarToContainingFrameViewBase(
- *this, local_rect);
- }
-
- return FrameViewBase::ConvertToContainingFrameViewBase(local_rect);
-}
-
-IntRect Scrollbar::ConvertFromContainingFrameViewBase(
- const IntRect& parent_rect) const {
- if (scrollable_area_) {
- return scrollable_area_->ConvertFromContainingFrameViewBaseToScrollbar(
- *this, parent_rect);
- }
-
- return FrameViewBase::ConvertFromContainingFrameViewBase(parent_rect);
-}
-
-IntPoint Scrollbar::ConvertToContainingFrameViewBase(
- const IntPoint& local_point) const {
- if (scrollable_area_) {
- return scrollable_area_->ConvertFromScrollbarToContainingFrameViewBase(
- *this, local_point);
- }
-
- return FrameViewBase::ConvertToContainingFrameViewBase(local_point);
-}
-
-IntPoint Scrollbar::ConvertFromContainingFrameViewBase(
- const IntPoint& parent_point) const {
- if (scrollable_area_) {
- return scrollable_area_->ConvertFromContainingFrameViewBaseToScrollbar(
- *this, parent_point);
+IntPoint Scrollbar::ConvertFromRootFrame(
+ const IntPoint& point_in_root_frame) const {
+ if (const FrameViewBase* parent = Parent()) {
+ IntPoint parent_point = parent->ConvertFromRootFrame(point_in_root_frame);
+ if (scrollable_area_) {
+ return scrollable_area_->ConvertFromContainingFrameViewBaseToScrollbar(
+ *this, parent_point);
+ }
}
- return FrameViewBase::ConvertFromContainingFrameViewBase(parent_point);
+ return point_in_root_frame;
}
float Scrollbar::ScrollableAreaCurrentPos() const {

Powered by Google App Engine
This is Rietveld 408576698