Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2832883003: Remove unneeded Convert* methods and move many from FrameViewBase to FrameView (Closed)
Patch Set: remove scrollbar convert methods Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index a172946d81a98602e132dadf8a2bb795fe0dbdc9..450d101619180dadb2e8bb94a68dca0820df450f 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -315,47 +315,6 @@ IntRect PaintLayerScrollableArea::ScrollCornerRect() const {
return IntRect();
}
-IntRect PaintLayerScrollableArea::ConvertFromScrollbarToContainingFrameViewBase(
- const Scrollbar& scrollbar,
- const IntRect& scrollbar_rect) const {
- LayoutView* view = Box().View();
- if (!view)
- return scrollbar_rect;
-
- IntRect rect = scrollbar_rect;
- rect.Move(ScrollbarOffset(scrollbar));
-
- return view->GetFrameView()->ConvertFromLayoutItem(LayoutBoxItem(&Box()),
- rect);
-}
-
-IntRect PaintLayerScrollableArea::ConvertFromContainingFrameViewBaseToScrollbar(
- const Scrollbar& scrollbar,
- const IntRect& parent_rect) const {
- LayoutView* view = Box().View();
- if (!view)
- return parent_rect;
-
- IntRect rect = view->GetFrameView()->ConvertToLayoutItem(
- LayoutBoxItem(&Box()), parent_rect);
- rect.Move(-ScrollbarOffset(scrollbar));
- return rect;
-}
-
-IntPoint
-PaintLayerScrollableArea::ConvertFromScrollbarToContainingFrameViewBase(
- const Scrollbar& scrollbar,
- const IntPoint& scrollbar_point) const {
- LayoutView* view = Box().View();
- if (!view)
- return scrollbar_point;
-
- IntPoint point = scrollbar_point;
- point.Move(ScrollbarOffset(scrollbar));
- return view->GetFrameView()->ConvertFromLayoutItem(LayoutBoxItem(&Box()),
- point);
-}
-
IntPoint
PaintLayerScrollableArea::ConvertFromContainingFrameViewBaseToScrollbar(
const Scrollbar& scrollbar,

Powered by Google App Engine
This is Rietveld 408576698