third_party/WebKit/Source/core/frame/RemoteFrameView.h - Issue 2832883003: Remove unneeded Convert* methods and move many from FrameViewBase to FrameView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrameView.h

Issue 2832883003: Remove unneeded Convert* methods and move many from FrameViewBase to FrameView (Closed)

Patch Set: fix ScrollableArea::ConvertFromScrollbarToContainingFrameViewBase and remove dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/RemoteFrameView.h

diff --git a/third_party/WebKit/Source/core/frame/RemoteFrameView.h b/third_party/WebKit/Source/core/frame/RemoteFrameView.h

index 886ec9a3d63e85ca2d5dee5f8dcd5e6df63e1fa9..2bd5d74d679a9133050dc1c2642b0e049900a605 100644

--- a/third_party/WebKit/Source/core/frame/RemoteFrameView.h

+++ b/third_party/WebKit/Source/core/frame/RemoteFrameView.h

@@ -45,6 +45,8 @@ class RemoteFrameView final : public FrameViewBase, public FrameOrPlugin {

void Show() override;

void SetParentVisible(bool) override;

+ IntRect ConvertFromContainingFrameViewBase(const IntRect&) const override;

DECLARE_VIRTUAL_TRACE();

private: