Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart

Issue 2832873002: Fix two analyzer warnings. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/gn_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart b/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
index 82ca0e94d61fdb369b504d2a174a9e22ca630e24..ac46c766394c796028e780fa262dded6bbeb52d1 100644
--- a/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
+++ b/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
@@ -238,14 +238,14 @@ class StatementCompletionProcessor {
return text;
}
- bool _complete_controlFlowBlock() {
messick 2017/04/20 17:30:49 You could fix the warning by calling this method f
devoncarew 2017/04/20 17:37:36 If this warning will be addressed shortly then I w
- //TODO(messick) Implement _complete_controlFlowBlock
- // Use statement completion to move the cursor to a new line outside the
- // current block. The statement has no errors in this case. Used to jump
- // out of do/for/if/while blocks.
- //TODO(messick) Move has-errors checking into dispatch method.
- return false;
- }
+// bool _complete_controlFlowBlock() {
+// //TODO(messick) Implement _complete_controlFlowBlock
+// // Use statement completion to move the cursor to a new line outside the
+// // current block. The statement has no errors in this case. Used to jump
+// // out of do/for/if/while blocks.
+// //TODO(messick) Move has-errors checking into dispatch method.
+// return false;
+// }
bool _complete_doStatement() {
if (errors.isEmpty || node is! DoStatement) {
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/gn_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698