Fix two analyzer warnings.

Fix two analyzer warnings.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3998e356790de28809c4d260606a5b4d4b1bbadb

[devoncarew, 2017-04-20 17:17:33]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, messick@google.com

[messick, 2017-04-20 17:30:50]

https://codereview.chromium.org/2832873002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(left):

https://codereview.chromium.org/2832873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:241:
bool _complete_controlFlowBlock() {
You could fix the warning by calling this method from compute(). Or, you could
wait for my next commit which will do that.

[devoncarew, 2017-04-20 17:37:36]

https://codereview.chromium.org/2832873002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(left):

https://codereview.chromium.org/2832873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:241:
bool _complete_controlFlowBlock() {
On 2017/04/20 17:30:49, messick wrote:
> You could fix the warning by calling this method from compute(). Or, you could
> wait for my next commit which will do that.

If this warning will be addressed shortly then I will revert this part of the
CL.

[messick, 2017-04-20 17:42:26]

On 2017/04/20 17:37:36, devoncarew wrote:
>
https://codereview.chromium.org/2832873002/diff/1/pkg/analysis_server/lib/src...
> File
>
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
> (left):
> 
>
https://codereview.chromium.org/2832873002/diff/1/pkg/analysis_server/lib/src...
>
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:241:
> bool _complete_controlFlowBlock() {
> On 2017/04/20 17:30:49, messick wrote:
> > You could fix the warning by calling this method from compute(). Or, you
could
> > wait for my next commit which will do that.
> 
> If this warning will be addressed shortly then I will revert this part of the
> CL.

Should be soon. I need to create half-a-dozen tests for completing
try-statements. The change you want is already in my current code.

[Brian Wilkerson, 2017-04-20 18:30:06]

lgtm

[devoncarew, 2017-04-20 18:32:54]

Description was changed from

==========
Fix two analyzer warnings.

BUG=
==========

to

==========
Fix two analyzer warnings.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3998e356790de28809c4d260606a5b4d4b1bbadb
==========

[devoncarew, 2017-04-20 18:32:55]

Committed patchset #2 (id:20001) manually as
3998e356790de28809c4d260606a5b4d4b1bbadb (presubmit successful).