Update avatar button to MD

chrome/browser/ui/views/frame/avatar_button_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_AVATAR_BUTTON_MANAGER_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_AVATAR_BUTTON_MANAGER_H_
 
 #include "chrome/browser/ui/views/profiles/avatar_button_delegate.h"
 #include "chrome/browser/ui/views/profiles/avatar_button_style.h"

[Peter Kasting, 2017/04/26 02:09:53]

Nit: Seems like you could forward-declare AvatarButton instead.

+#include "chrome/browser/ui/views/profiles/new_avatar_button.h"
+#include "ui/views/controls/button/menu_button.h"

[Peter Kasting, 2017/04/26 02:09:53]

Nit: Seems like you shouldn't need this (we should have the necessary prototype
from our superclass).

[emx, 2017/04/27 16:30:58]

Done.

 
 class BrowserNonClientFrameView;
 
 // Manages an avatar button displayed in a browser frame. The button displays
 // the name of the active or guest profile, and may be null.
 class AvatarButtonManager : public AvatarButtonDelegate {
  public:
   explicit AvatarButtonManager(BrowserNonClientFrameView* frame_view);
 
   // Adds or removes the avatar button from the frame, based on the BrowserView
   // properties.
   void Update(AvatarButtonStyle style);
 
-  // Gets the avatar button as a view::View.
-  views::View* view() const { return view_; }
+  AvatarButton* button() const { return button_; }

[Peter Kasting, 2017/04/26 02:09:53]

Const methods should not return non-const pointers; make method non-const or
pointer const.

 
- private:
   // AvatarButtonDelegate:
   void ButtonPreferredSizeChanged() override;
 
-  // views::ButtonListener:
-  void ButtonPressed(views::Button* sender, const ui::Event& event) override;
+ private:
+  // views::MenuButtonListener:

[Peter Kasting, 2017/04/26 02:09:53]

Nit: You don't directly inherit from AvatarButtonDelegate, so prefer to label
this as coming from that.

Per recent discussion on chromium-dev, overrides should match the visibility of
their parent, so this function should probably be public.

[emx, 2017/04/27 16:30:58]

Done.

+  void OnMenuButtonClicked(views::MenuButton* source,
+                           const gfx::Point& point,
+                           const ui::Event* event) override;
 
   BrowserNonClientFrameView* frame_view_;  // Weak. Owns |this|.
 
   // Menu button that displays the name of the active or guest profile.
   // May be null and will not be displayed for off the record profiles.
-  views::View* view_;  // Owned by views hierarchy.
+  AvatarButton* button_;  // Owned by views hierarchy.
 
   DISALLOW_COPY_AND_ASSIGN(AvatarButtonManager);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_AVATAR_BUTTON_MANAGER_H_